all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Improve the error report of format
@ 2024-04-18  9:52 Martin Edström
  2024-04-18 11:32 ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Edström @ 2024-04-18  9:52 UTC (permalink / raw)
  To: emacs-devel


Background: I am currently trying to find out where an error "Format
specifier doesn't match argument type" is coming from.  It's a bit of a
mystery, so I thought, hey, this could be a lot easier if the error
message includes the format string that it is trying to print!  That way
it would be a simple search across a codebase.

TL;DR: can format's error message include the input string?

Thanks,

Martin



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Improve the error report of format
  2024-04-18  9:52 Improve the error report of format Martin Edström
@ 2024-04-18 11:32 ` Eli Zaretskii
  2024-04-18 13:46   ` Martin Edström
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2024-04-18 11:32 UTC (permalink / raw)
  To: Martin Edström; +Cc: emacs-devel

> From: Martin Edström <meedstrom@runbox.eu>
> Date: Thu, 18 Apr 2024 11:52:34 +0200
> 
> 
> Background: I am currently trying to find out where an error "Format
> specifier doesn't match argument type" is coming from.

It comes from editfns.c, from the function styled_format.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Improve the error report of format
  2024-04-18 11:32 ` Eli Zaretskii
@ 2024-04-18 13:46   ` Martin Edström
  2024-04-18 14:17     ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Edström @ 2024-04-18 13:46 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel


Hi Eli,

Thank you.  I meant where in my Elisp codebase that triggers the error
:-) I have since fixed the problem, but my proposal would still be
good for dev experience, in my opinion.

Actually my FSF assignment is pending, so I could patch editfns.c for
you.  Would you accept such a patch?

Martin Edström

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Martin Edström <meedstrom@runbox.eu>
>> Date: Thu, 18 Apr 2024 11:52:34 +0200
>>
>>
>> Background: I am currently trying to find out where an error "Format
>> specifier doesn't match argument type" is coming from.
>
> It comes from editfns.c, from the function styled_format.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Improve the error report of format
  2024-04-18 13:46   ` Martin Edström
@ 2024-04-18 14:17     ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2024-04-18 14:17 UTC (permalink / raw)
  To: Martin Edström; +Cc: emacs-devel

> From: Martin Edström <meedstrom@runbox.eu>
> Cc: emacs-devel@gnu.org
> Date: Thu, 18 Apr 2024 15:46:20 +0200
> 
> Thank you.  I meant where in my Elisp codebase that triggers the error
> :-) I have since fixed the problem, but my proposal would still be
> good for dev experience, in my opinion.
> 
> Actually my FSF assignment is pending, so I could patch editfns.c for
> you.  Would you accept such a patch?

Don't see why not.  Bonus points for adding a test for this.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-18 14:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-18  9:52 Improve the error report of format Martin Edström
2024-04-18 11:32 ` Eli Zaretskii
2024-04-18 13:46   ` Martin Edström
2024-04-18 14:17     ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.