From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#72831: [PATCH] gnus-icalendar: Allow comments in event replies Date: Thu, 29 Aug 2024 09:52:37 +0200 Message-ID: <87o75bvk8q.fsf@gmail.com> References: <875xrml22f.fsf@pie.tf> <868qwgj4fh.fsf@gnu.org> <87wmk0vk0p.fsf@gmail.com> <878qwgtxjo.fsf@pie.tf> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26386"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Andrew G Cohen , Alexandre Duret-Lutz , 72831@debbugs.gnu.org To: Ferdinand Pieper Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 29 09:54:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sjZzC-0006hQ-Qs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Aug 2024 09:54:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjZyr-0002AI-Mw; Thu, 29 Aug 2024 03:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjZyq-0001xn-5R for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2024 03:54:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sjZyp-0003Fc-Qy for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2024 03:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=cXCZtZAt/tporCYmQ7k54VK7GW8IG1kiuvvVcRNAHU8=; b=C/d2ukeF61ACpHGFR6ja9OyrwrvDYrztaEQlmhPckXMxZmlVJ05p4/BKyFTKef/cUCTp8ATyuOSGRwzgtI96s6mCcvftQv3D/YJSbuCalcGwc4h2IiPDENMvGK/b3IQIv04XgZc3hTY/apqEC65ym5A03G+o83p70zUhXUBVXTZnF1opLM9caCU4QpwIRwg5KXhio6Mrui6UYgJ8L2/pRYHNNX0fATIYlJQksWKyucWCfYXnohZxHT5vc+sh4ed/FpiFfZg8Kt+Q3lP9OYPrhwY4JVd9v4FOhpJTB014QDMNQTAw9r+6UXwsE4v49KiTyjBIEFn/hp9h33tLNIrJWw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sjZzh-00060g-Qj for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2024 03:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Aug 2024 07:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72831-submit@debbugs.gnu.org id=B72831.172491808423066 (code B ref 72831); Thu, 29 Aug 2024 07:55:01 +0000 Original-Received: (at 72831) by debbugs.gnu.org; 29 Aug 2024 07:54:44 +0000 Original-Received: from localhost ([127.0.0.1]:50304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjZzP-0005zy-LP for submit@debbugs.gnu.org; Thu, 29 Aug 2024 03:54:43 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:50511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjZzN-0005zi-9Y for 72831@debbugs.gnu.org; Thu, 29 Aug 2024 03:54:43 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3719398eafcso239613f8f.1 for <72831@debbugs.gnu.org>; Thu, 29 Aug 2024 00:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724917960; x=1725522760; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=cXCZtZAt/tporCYmQ7k54VK7GW8IG1kiuvvVcRNAHU8=; b=gf89FxqLYCues0E6kpHpf0bdEUqmOJVhDOY8mmWElX6LxoFfsCZC+wAEoQ7Xz5jTdh 7+WMK1nIb8yA7lIzvukoLVC1883+3p/CcvEn01H/Xi2DEGgiTbse+F6nJnpCUaydaeUV gdI6lpSxw+D/QV0SjPjOXgC/cx+Mjm+3+cystPOBlA0zR6Af6i5Upk7JcT4ZxGgAlDAh i5Z6iTyUB44u2kh0M2PTQyMfg7/6oqmEXA+WHBKVOfkOU3YaG4y3bOH2anF1/brllnO6 zsrn1JPcT2KJ7pppe2N1U5Vyk+8nM3oE19jLz8pKkwZNHkpg8gxncFktwkB248fZm5CL xdZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724917960; x=1725522760; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cXCZtZAt/tporCYmQ7k54VK7GW8IG1kiuvvVcRNAHU8=; b=BHlkMGgf3Wb7zuFzs1xPLUt8ozpSyQ3urB6QO9GfGOdwzMLo/HPpBLfYx3Ki3jKbmG tHlABMfsvr7w+zvRujfCrJbLboLI3JOezZKa4EptMsZgmTDfouGbRpwA5klanVY90PfF BmK0IloK8YUkTnn4cuIYEb56QUsTVJUPI/QcMHGCk+99on+1Ad1Ss+o+/roN2AP3n8KN 8zCqFMlBJEqsNHQ5WRHOjM98jLFi2WHcfZ4jOVvx34KoIZWGZGz+OasWccPWkXsnJXie LmE39UeRHj81raZfNpNAwsuJ+yzvWIdoUTK8k3kCVBQ1RH0EeRRkQpTtveM8hDkILLeV W+YQ== X-Forwarded-Encrypted: i=1; AJvYcCWiTv6z4OMZx16qDdhi6pLdr7piV/XnMOQg8YXz5FRwO1EV2e0JMzRgsdJpWwfALWHRxo9JkQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx8YQFhZU+M9yVoeN8uywnbtAQOpiPeAe29m/Qt7px8/nKAmUnt fHzhfvuX3Qx5jEz6VX2ffp1bWgnQveP5RwSgOcAwgm15YmNqH+LBq5OKgQ== X-Google-Smtp-Source: AGHT+IGiWjfsJPg8VfCEuNU4rh56uJfxl2Rv+xAScO3fCCYJFUSpEZZSOFToofV0xTF8U0ZHd2hZdQ== X-Received: by 2002:adf:f2cc:0:b0:371:8c9c:d97f with SMTP id ffacd0b85a97d-3749b55004amr1323178f8f.10.1724917959404; Thu, 29 Aug 2024 00:52:39 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb51:bbad:a24b:6515:8016]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee9c188sm727670f8f.55.2024.08.29.00.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 00:52:38 -0700 (PDT) In-Reply-To: <878qwgtxjo.fsf@pie.tf> (Ferdinand Pieper's message of "Wed, 28 Aug 2024 18:35:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290915 Archived-At: >>>>> On Wed, 28 Aug 2024 18:35:55 +0200, Ferdinand Pieper said: >> So if the event was sent with a COMMENT the receiver can=CA=BCt add = their >> own? That doesn=CA=BCt match my conception of 'reply with comment'. = I=CA=BCm >> hazy on what=CA=BCs exactly allowed in ical, can you have more than = one >> COMMENT line? Or we could combine the comments? Ferdinand> If it already exists it is replaced by the prior >> >> ((string=3D key "COMMENT") (update-comment line)) Ferdinand> Just if it does not exist the `(string=3D key "COMMENT")` ne= ver matches and we have to add the field. Sorry, I missed that bit. >> I think we tend to word this as >>=20 >> "Optional argument COMMENT-P (interactively the prefix argument) mea= ns >> prompt for a comment to include in the reply." Ferdinand> Updated using `\\[universal-argument]'. Or does that not mat= ter here and just "prefix argument" would be fine? Either one is fine I think. >> Ideally you=CA=BCd add test cases for this to >> "test/lisp/gnus/gnus-icalendar-tests.el". But that=CA=BCs not mandat= ory. Ferdinand> I looked into it and will add a few tests for accepting/decl= ining events with and without comments. I will followup on this in a couple= days. Ferdinand> It might also make sense to extend the parsing of events to = recognize comments (and potentially display them inside emacs. That would be good as a followup patch. Robert --=20