From: Robert Pluim <rpluim@gmail.com>
To: Ferdinand Pieper <list_gnu@pie.tf>
Cc: Eli Zaretskii <eliz@gnu.org>, Andrew G Cohen <cohen@andy.bu.edu>,
Alexandre Duret-Lutz <adl@lrde.epita.fr>,
72831@debbugs.gnu.org
Subject: bug#72831: [PATCH] gnus-icalendar: Allow comments in event replies
Date: Thu, 29 Aug 2024 09:52:37 +0200 [thread overview]
Message-ID: <87o75bvk8q.fsf@gmail.com> (raw)
In-Reply-To: <878qwgtxjo.fsf@pie.tf> (Ferdinand Pieper's message of "Wed, 28 Aug 2024 18:35:55 +0200")
>>>>> On Wed, 28 Aug 2024 18:35:55 +0200, Ferdinand Pieper <list_gnu@pie.tf> said:
>> So if the event was sent with a COMMENT the receiver canʼt add their
>> own? That doesnʼt match my conception of 'reply with comment'. Iʼm
>> hazy on whatʼs exactly allowed in ical, can you have more than one
>> COMMENT line? Or we could combine the comments?
Ferdinand> If it already exists it is replaced by the prior
>> >> ((string= key "COMMENT") (update-comment line))
Ferdinand> Just if it does not exist the `(string= key "COMMENT")` never matches and we have to add the field.
Sorry, I missed that bit.
>> I think we tend to word this as
>>
>> "Optional argument COMMENT-P (interactively the prefix argument) means
>> prompt for a comment to include in the reply."
Ferdinand> Updated using `\\[universal-argument]'. Or does that not matter here and just "prefix argument" would be fine?
Either one is fine I think.
>> Ideally youʼd add test cases for this to
>> "test/lisp/gnus/gnus-icalendar-tests.el". But thatʼs not mandatory.
Ferdinand> I looked into it and will add a few tests for accepting/declining events with and without comments. I will followup on this in a couple days.
Ferdinand> It might also make sense to extend the parsing of events to recognize comments (and potentially display them inside emacs.
That would be good as a followup patch.
Robert
--
next prev parent reply other threads:[~2024-08-29 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 9:58 bug#72831: [PATCH] gnus-icalendar: Allow comments in event replies Ferdinand Pieper
2024-08-28 11:02 ` Eli Zaretskii
2024-08-28 13:45 ` Robert Pluim
2024-08-28 15:47 ` Eli Zaretskii
2024-08-28 16:35 ` Ferdinand Pieper
2024-08-29 7:52 ` Robert Pluim [this message]
2024-08-31 14:31 ` Ferdinand Pieper
2024-09-07 12:22 ` Ferdinand Pieper
2024-09-07 14:55 ` Eli Zaretskii
2024-09-07 15:05 ` Ferdinand Pieper
2024-09-11 8:13 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o75bvk8q.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=72831@debbugs.gnu.org \
--cc=adl@lrde.epita.fr \
--cc=cohen@andy.bu.edu \
--cc=eliz@gnu.org \
--cc=list_gnu@pie.tf \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.