From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Nordin Newsgroups: gmane.emacs.bugs Subject: bug#72556: 29.1.90; vc-diff does not undo hunk in end of source file Date: Sun, 15 Sep 2024 10:41:45 +0000 Message-ID: <87o74pmc5y.fsf@posteo.net> References: <87ttfs60ir.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14114"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , 72556@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 15 12:43:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spmic-0003Wd-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Sep 2024 12:43:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spmiT-0003IW-D7; Sun, 15 Sep 2024 06:42:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spmiQ-0003II-Kd for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2024 06:42:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spmiQ-00077B-Au for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2024 06:42:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8P+ShNQoEjj+OLPuNSy5DgYm/67RM53GrGA1Ofk2F0A=; b=aY0G9K1fJa1dO86Aa89jTqcSKH2KN7ZYUFTrlx5i9cmtHelung9EZuMzneEqO13kVK794F7qsVNnyQ+3azxScUYU/i0KafKFQfJCNf1vCZ5EBKsPzQvRx/JA7o0SxTsw820/8YWIZ5EXKze96sqVg2BUKSF2aAvZpYwD0s7KM+Q8iH6v7KPFPfJ0LOh7qODbCJRLOWeSezdHu+XJVuSYEB60plNnu7qQosQE4rxjVxoL+COENnPnqn2znNSNsjIsAnsb/9QhVLrg6dejcH1hzkr3J2kfcuEDwPDkbC4ZcrpajyykoysVPaHkScf0/zOcGbY3XqAbo5qgOQyEfP79bQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spmic-0003xV-1t for bug-gnu-emacs@gnu.org; Sun, 15 Sep 2024 06:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tomas Nordin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Sep 2024 10:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72556 X-GNU-PR-Package: emacs Original-Received: via spool by 72556-submit@debbugs.gnu.org id=B72556.172639692915138 (code B ref 72556); Sun, 15 Sep 2024 10:43:02 +0000 Original-Received: (at 72556) by debbugs.gnu.org; 15 Sep 2024 10:42:09 +0000 Original-Received: from localhost ([127.0.0.1]:48497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spmhl-0003w6-0Q for submit@debbugs.gnu.org; Sun, 15 Sep 2024 06:42:09 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:41487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spmhi-0003vZ-Jw for 72556@debbugs.gnu.org; Sun, 15 Sep 2024 06:42:07 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8279B240101 for <72556@debbugs.gnu.org>; Sun, 15 Sep 2024 12:41:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726396908; bh=5XCZ9bLwSmynwvffyzE7XA7/8QsC980+ITgdw8xna/4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=KUW+3bCdH2yIdSfldheEokK5/xCx1GhDe0uEsTk6SLHDZSE7lg8z609B7+HsL+A6Z NH25RKtp4O1DmC7EdjXNTKSX+khTe9XzxQNp1AiOtsw46POMH30pHEZPEigOTMk9Pm QpvaDKtB6vma0Mio8UmUi2nqHKL72Nh1lCslqm3kgRKNqWA09MNTvMbKgUkfyajbTJ 5npRhU9SsSMddCOoUXI3V8W7VWmdXO/PWbHxIzDCtTBYRdXKFGJbprRqlEvpZR7joV NCnWBa+fHWBfbh+DkeQx2OMxwZ2wXHVpkq+PjFU6zy1QtamrolyoZpTQTFHBuJj0/z Yjr8fL5vqQOBg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X64NV1j9Dz6tvp; Sun, 15 Sep 2024 12:41:45 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291845 Archived-At: Dmitry Gutov writes: > Hi! > > On 10/08/2024 15:11, Tomas Nordin wrote: >> I have >> noticed that if the diff hunk is an addition in the end of the source >> file, I dont get the expected question if I want to undo the hunk. >> Instead, the hunk is applied again. > > No matter the resolution of this bug, just wanted to make sure you know > that you can force the reverse direction by adding the prefix to the > command. > > So while 'C-c C-a' applies the hunk, 'C-u C-c C-a' reverses it (with a > similar check that sees whether the hunk has been applied already). I was loosely aware of that but never got it into my fingers. Instead I was relying on that dwim behavior of diff-mode. But trying the prefix variant out, it seems to be a solid way of "un-applying" a hunk. Might not be worth the trouble to try and fix this problem if it is complicated. There is a solid way to do what I want (which is maybe the proper way), and my complaint about this is the only one I have seen. A wont-fix is fine with me.