From: Robert Pluim <rpluim@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 73175@debbugs.gnu.org
Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons
Date: Tue, 24 Sep 2024 11:29:45 +0200 [thread overview]
Message-ID: <87o74de6wm.fsf@gmail.com> (raw)
In-Reply-To: <86setpd07a.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 24 Sep 2024 09:39:53 +0300")
>>>>> On Tue, 24 Sep 2024 09:39:53 +0300, Juri Linkov <juri@linkov.net> said:
Juri> Probably it would be the right thing to move this code to `button-mode'
Juri> to remove properties when it's disabled.
>>
Robert> That would be best (assuming Iʼve got the incantation right ;-))
>>
>> Although `button-mode' is described as a mode for button
>> *navigation*, so changing its behaviour might annoy people. Weʼll let the
>> maintainers decide that one ☺️
Juri> The change will fix its behaviour only for disabling with
Juri> (button-mode -1). I don't see how this might annoy people.
Juri> It's the standard thing for a mode to clean up after itself.
OK. Are we agreed that `unbuttonize-region' is a good name before I
update the manual?
(Hmm, `buttonize-region' isnʼt in the elisp manual. Iʼm assuming
emacs-30 is still open for documentation changes, if not I can fix
that on master.)
Robert
--
next prev parent reply other threads:[~2024-09-24 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 9:42 bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Robert Pluim
2024-09-20 6:52 ` Juri Linkov
2024-09-20 8:57 ` Robert Pluim
2024-09-20 12:49 ` Robert Pluim
2024-09-24 6:39 ` Juri Linkov
2024-09-24 9:29 ` Robert Pluim [this message]
2024-09-24 12:25 ` Eli Zaretskii
2024-09-24 15:59 ` Robert Pluim
2024-10-11 10:18 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o74de6wm.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=73175@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.