From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73604: [PATCH] Properly operate on current fileset revision in vc-hg-print-log Date: Thu, 03 Oct 2024 15:04:51 +0800 Message-ID: <87o741zmy4.fsf@melete.silentflame.com> References: <87o7422any.fsf@melete.silentflame.com> <86o741znlb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23541"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 73604@debbugs.gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 03 09:06:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swFug-0005yR-L3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Oct 2024 09:06:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swFuW-0008A7-Mh; Thu, 03 Oct 2024 03:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swFuT-00089j-Kh for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 03:06:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swFuT-0004Hs-Cc for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 03:06:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=m0iT8ghED2yuQTG19rvLyiixxVhpqFgwZkvRliLqhJc=; b=nIedYLBlrVCtZSRoP7sbV0DyrqQmsZOPVlU+L7sNZ46ucKbWtJseOhr5aC1zYk1HhwqTzcqtAck/FncXVcB/KArI1muYka+02drAFWPEcXh1jbJH020U2D5qNL0lFmVM/x+/ujMGNRSJQffQtJebcQYKPXahfIth3ZI/2hOCu2g4VaXg+oGwoVIR81AAvZR84r2cMS0j5MxLjg5xkwodeaZa6dy78gmjDmS2PvKXYTiDrr1bXUt3rwmRn7MRv7+eqMm0Vx81njxf8c0HFTQxvwvJWclE4pi0Ep1NMJMEKe0q/h7GDunLhQNNntwkKbo/v/hSCYBZU1Ad/Y0KVuu+hQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swFuU-0000oJ-BO for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 03:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2024 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73604-submit@debbugs.gnu.org id=B73604.17279391072711 (code B ref 73604); Thu, 03 Oct 2024 07:06:02 +0000 Original-Received: (at 73604) by debbugs.gnu.org; 3 Oct 2024 07:05:07 +0000 Original-Received: from localhost ([127.0.0.1]:59811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFtb-0000gh-2N for submit@debbugs.gnu.org; Thu, 03 Oct 2024 03:05:07 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:56010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swFtY-0000eL-J2 for 73604@debbugs.gnu.org; Thu, 03 Oct 2024 03:05:05 -0400 DKIM-Signature: a=rsa-sha256; b=dJY34sACHZSKJe1CTt50ScXRO0vtxNjXFqqaWltvJ2pUPEctDTrn9G5VAmCakBP/foWozM2Fcz5PoZb/BpoKyJfEziQKnaymPoH3omxmJO2sF851Vy8NTB1rISgzZfgzCez+A00c9S2vW/VzrViDmB+xXtsKoyQ1KkJgjL8lei7L/xajcl9mj7BYjMf7NWjf4hh7NToTC+8kDVSPjEmbguD9ANjDQRaJTkf0lx0Fp2KTi2tluPdx945NFyenqhv3Wd9hgnkgMvRsaScRTldm/DiltHirEPrbAqmZuV0HQ9LwxZfwu+kAJeklRRYvjfTuR9OB/ICG5uPulmUS6YkYGw==; s=purelymail2; d=spwhitton.name; v=1; bh=rIqyqUVGwxByME0l9+LUBdjmaBQeuFILGWDp+Bio5YM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=CxLVwBKUo/5MPYCNohqghbAhYXmUwzBK2W2ufcofvU29MU+VIY4xoFCSGlwQLiHsIw5g1jYxsawHd+sh9cl5y1EbViGXWXgBNknTvq6GjhUOF+8kSv0aym6e1rgpUJygnzyyS6yZj3NLogtP4dAMsojw6DrGBDNLBJylyjfYhCrHxpgCgWyQV2lfqcy2CNpGPnJ/f48u2ZZFoOxfcPKdroq3bsO2T7pdyxAuyWVsPGUDy9YslPglIy847tV/js4IAfDVwLXcm32l+8d0cAkapI/a+Rn5/CO7AS6BxPWYGEhecKOdw0uDYodf6H29rKzvEErCvvPS7SKqhmbK+cmXag==; s=purelymail2; d=purelymail.com; v=1; bh=rIqyqUVGwxByME0l9+LUBdjmaBQeuFILGWDp+Bio5YM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73604@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1414736344; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 03 Oct 2024 07:04:56 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id B23427E0C67; Thu, 3 Oct 2024 15:04:51 +0800 (CST) In-Reply-To: <86o741znlb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Oct 2024 09:50:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292887 Archived-At: Hello, On Thu 03 Oct 2024 at 09:50am +03, Eli Zaretskii wrote: >> From: Sean Whitton >> Cc: Spencer Baugh , 73604@debbugs.gnu.org >> Date: Thu, 03 Oct 2024 10:16:33 +0800 >> >> Eli, can this go on emacs-30? > > Why is it important enough to install on emacs-30? The situation > sounds quite rare to me. Yeah, it's relatively rare, but I was thinking that it would be appropriate because of the simplicity of the fix. Anyway, master is fine, I just wanted to ask. > Moreover, I'm not sure the change is correct in general. If you > invoke "C-x v l" with an argument, the prompt says "...(default: last > revision)". It says "last", and doesn't say anything about the > working revision. So I don't understand why you say the current > operation of the command is incorrect even when the tip and the > current working revision are different. I think this is precisely a > use case where the user should invoke the command with a prefix arg > and specify the revision from which to start. Well, the description of C-x v l is Show in another window the VC change history of the current fileset. If the current fileset doesn't exist in tip, then we'd better not just log tip. Possibly the prompt should also change. Let's see what Spencer thinks. -- Sean Whitton