From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#73812: 30.0.91; ERC 5.6.0.30.1: Customizing erc-modules loads ERC when starting Emacs Date: Mon, 14 Oct 2024 19:57:00 -0700 Message-ID: <87o73mgjk3.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, Eli Zaretskii To: 73812@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 15 05:00:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0Xn7-0006yi-V2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Oct 2024 05:00:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0Xmo-00033S-GR; Mon, 14 Oct 2024 22:59:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0Xmk-00033B-Dl; Mon, 14 Oct 2024 22:59:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0Xmj-0004D3-SH; Mon, 14 Oct 2024 22:59:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=kx8DRQFB29lbmQU5TNtJlOGcq72kJ7h+4uO/IHD6EuM=; b=Xgq8oNcV84L5o/o34qq8NpXN7K4QIQHvruHMC/Fu0l0g61an8bFM2LlQAafNmYoQ6qrkUTf4GYTv2A6CmM/cSur95kmnO9wE5jYVRNEK8XE1F1ZinEiO4+SB+Miv/t8sKpmdar/JY0uh2hNtOF5THsnMC3NTEVKtbFXnf5vhSS5U0ZNAO+wQUbbl1uMhnf6OrIG2pTWoIRrBJU1kFNsuosB1vPonvBsLx9SWuUtWP5WYoYgnf2H3YUqMmSvRUxsVZQ1R+EC12UTIHpDXbFsFhMqxJsCWXgWgZvJRhvL6ZYs+Dxw49rqOcuEWfoEmYUw2TW/V5ENOuTVXIous9QPl+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0Xn1-0002nz-12; Mon, 14 Oct 2024 23:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: emacs-erc@gnu.org, eliz@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2024 03:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73812 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: emacs-erc@gnu.org, Eli Zaretskii Original-Received: via spool by submit@debbugs.gnu.org id=B.172896117910687 (code B ref -1); Tue, 15 Oct 2024 03:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2024 02:59:39 +0000 Original-Received: from localhost ([127.0.0.1]:49848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0Xmc-0002mH-Gq for submit@debbugs.gnu.org; Mon, 14 Oct 2024 22:59:39 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:45352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0Xma-0002m0-2i for submit@debbugs.gnu.org; Mon, 14 Oct 2024 22:59:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0XkC-0002sv-3a for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 22:57:08 -0400 Original-Received: from mail-108-mta80.mxroute.com ([136.175.108.80]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0XkA-00042G-2I for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 22:57:07 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta80.mxroute.com (ZoneMTA) with ESMTPSA id 1928e1b88c30003e01.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Oct 2024 02:57:02 +0000 X-Zone-Loop: e99cee45dbb71855fef66e956cdabdfdad9a9c186339 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kx8DRQFB29lbmQU5TNtJlOGcq72kJ7h+4uO/IHD6EuM=; b=LmO2tyBZWrL5LI7cK7lVaEFlRP 3pQrOnBr8oyeBiYf0TejrE6WB4nzCduhimv1fFUqS6tHDbEaBD5RQZVljWo6+R7x33hDY6A7HtRn5 KKfEaOgex+HxJaMGPCIv7ViSC9srpiHtgTDhSfhepcbft+R7ysb27Kx53R0tvjc4AQWW6/PJMgwVV 7qvIjjimzA2IdAyOaLORk/cIGgvoWukRNP9cEPRztsKDY58cfh4P0KxRiXJGMu0AIwleNhVogCZdF XsVftxaPxRdnvQBZVuYCDH4SP+kQ9kPept01acoSGKa2XDHbuh6N1LRy5WO8twU1cXXPpucyACavv z5U2gTaQ==; X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.80; envelope-from=jp@neverwas.me; helo=mail-108-mta80.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293601 gmane.emacs.erc.general:2576 Archived-At: --=-=-= Content-Type: text/plain Tags: patch >From emacs -Q 1. $ mkdir /tmp/fake-home 2. $ echo "(custom-set-variables '(erc-modules ()))" > /tmp/fake-home/.emacs 3. $ HOME=/tmp/fake-home ./src/emacs 4. M-: (featurep 'erc) RET Eli, can we add this patch to the release branch? It removes a single line containing an autoload cookie that's new in Emacs 30. (I'm running the check-expensive suite with the patch now.) Thanks. In GNU Emacs 30.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-10-14 built on localhost Repository revision: b87fda63dd4a29c3c28e235904405f2d6709239e Repository branch: emacs-30 Windowing system distributor 'The X.Org Foundation', version 11.0.12401002 System Description: Fedora Linux 40 (Workstation Edition) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils compile text-property-search comint ansi-osc ansi-color ring comp-run comp-common erc derived auth-source eieio eieio-core icons password-cache json map format-spec erc-backend erc-networks easy-mmode byte-opt bytecomp byte-compile erc-common inline cl-extra help-mode erc-compat cl-seq cl-macs gv pcase rx compat subr-x cl-loaddefs cl-lib erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 166001 9858) (symbols 48 11695 0) (strings 32 30570 5080) (string-bytes 1 1067417) (vectors 16 19000) (vector-slots 8 192763 8903) (floats 8 35 1) (intervals 56 339 0) (buffers 984 11)) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Don-t-autoload-erc-modules.patch >From 560390753c087a8e0dd8e6e1d2803ff8fff4cf24 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Mon, 14 Oct 2024 19:32:16 -0700 Subject: [PATCH] Don't autoload erc-modules * lisp/erc/erc.el (erc-modules): Remove autoload because it caused customizations for this option to load the main library. This reverts the thrust of bb894845 "Teach customize-option about erc-modules", which was added in ERC 5.6 and Emacs 30. The motivation for the original offending change was to allow new users to run M-x customize-option RET erc-modules RET immediately after start up instead of M-x customize-group RET, followed by an I-search. --- lisp/erc/erc.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 30641c2bd88..688d2f4b1ae 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -2263,8 +2263,6 @@ erc--sort-modules (cl-pushnew mod (if (get mod 'erc--module) built-in third-party))) `(,@(sort built-in #'string-lessp) ,@(nreverse third-party)))) -;;;###autoload(custom-autoload 'erc-modules "erc") - (defcustom erc-modules '( autojoin button completion fill imenu irccontrols list match menu move-to-prompt netsplit networks readonly ring stamp track) -- 2.46.2 --=-=-=--