Re: master 298bbf3cd76: * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.

Re: master 298bbf3cd76: * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.

[Robert Pluim]

>>>>> On Tue, 26 Nov 2024 17:04:05 -0500 (EST), Dmitry Gutov <dgutov@yandex.ru> said:

    Dmitry> branch: master
    Dmitry> commit 298bbf3cd76ffaf0c88a6a9ec56aa33c4103b8e6
    Dmitry> Author: Dmitry Gutov <dmitry@gutov.dev>
    Dmitry> Commit: Dmitry Gutov <dmitry@gutov.dev>

    Dmitry>     * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.
    Dmitry> ---
    Dmitry>  lisp/files.el | 5 ++++-
    Dmitry>  1 file changed, 4 insertions(+), 1 deletion(-)

    Dmitry> diff --git a/lisp/files.el b/lisp/files.el
    Dmitry> index 72f3604054e..a65bc4a4ea2 100644
    Dmitry> --- a/lisp/files.el
    Dmitry> +++ b/lisp/files.el
    Dmitry> @@ -3621,7 +3621,10 @@ instead.
    Dmitry>  FUNCTION is typically a major mode which \"does the same thing\" as
    Dmitry>  MODE, but can also be nil to hide other entries (either in this var or
    Dmitry>  in `major-mode-remap-defaults') and means that we should call MODE."
    Dmitry> -  :type '(alist (symbol) (function)))
    Dmitry> +  :type '(alist
    Dmitry> +          :tag "Remappings"
    Dmitry> +          :key-type (symbol :tag "From major mode")
    Dmitry> +          :value-type (function :tag "To mode (or function)")))

Is this close enough to a documentation change that we could apply it
to emacs-30?

Robert
-- 

Re: master 298bbf3cd76: * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Dmitry Gutov <dmitry@gutov.dev>
> Date: Wed, 27 Nov 2024 09:51:23 +0100
> 
> >>>>> On Tue, 26 Nov 2024 17:04:05 -0500 (EST), Dmitry Gutov <dgutov@yandex.ru> said:
> 
>     Dmitry> branch: master
>     Dmitry> commit 298bbf3cd76ffaf0c88a6a9ec56aa33c4103b8e6
>     Dmitry> Author: Dmitry Gutov <dmitry@gutov.dev>
>     Dmitry> Commit: Dmitry Gutov <dmitry@gutov.dev>
> 
>     Dmitry>     * lisp/files.el (major-mode-remap-alist): Add :tag annotations to :type.
>     Dmitry> ---
>     Dmitry>  lisp/files.el | 5 ++++-
>     Dmitry>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>     Dmitry> diff --git a/lisp/files.el b/lisp/files.el
>     Dmitry> index 72f3604054e..a65bc4a4ea2 100644
>     Dmitry> --- a/lisp/files.el
>     Dmitry> +++ b/lisp/files.el
>     Dmitry> @@ -3621,7 +3621,10 @@ instead.
>     Dmitry>  FUNCTION is typically a major mode which \"does the same thing\" as
>     Dmitry>  MODE, but can also be nil to hide other entries (either in this var or
>     Dmitry>  in `major-mode-remap-defaults') and means that we should call MODE."
>     Dmitry> -  :type '(alist (symbol) (function)))
>     Dmitry> +  :type '(alist
>     Dmitry> +          :tag "Remappings"
>     Dmitry> +          :key-type (symbol :tag "From major mode")
>     Dmitry> +          :value-type (function :tag "To mode (or function)")))
> 
> Is this close enough to a documentation change that we could apply it
> to emacs-30?

I don't mind backporting it, but it sounds like Juri was not happy
with some aspect of the change?