From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Santos via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75410: [PATCH] image-dired: Add extra keybinds for navigation Date: Mon, 06 Jan 2025 17:07:24 -0300 Message-ID: <87o70j4sg3.fsf@disroot.org> Reply-To: Gabriel Santos Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10469"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas To: 75410@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 06 21:09:17 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUtPZ-0002ZU-29 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Jan 2025 21:09:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUtPP-0000Xc-Vd; Mon, 06 Jan 2025 15:09:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUtPK-0000X5-BQ for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:09:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUtPK-0004DG-2i for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:09:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=UeI8ZjU1dW1PjChVmoPTSIOjC3lP59vnKiHJGsw8gPI=; b=FP/UO3ehyw2cqNo0eT38dktCo8jpMvpjy4crbDigqRM5HWpHoSiphGSv/2l3ucZKdlOVBqr5PKUp+grXzU2Km8KMrJWn92x51xzLcyo8CNVhh3DYAXj2IaSfnz6pqv/cYcW65mgJL77gJtrNK6IahHnlzlkfQTAnwMaLHQKxUoP0zh3mTBtTK3U93Bfl/lkN1Sk9GaXE6JzV9fL3RhrjgfE2iAW7GLBYcL7/UhLovWVXusHET/Trj90jEJRgfGwGtMevHDSfD2hWhZWhiGbzpGQS0p9Bv0c4BfhzuBD6CpMpvyRnGGSJtN2n6wl6S+aCOEgQ60Hr6x81GG3/p2ihxw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUtPJ-0008EN-SC for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Santos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2025 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.173619408431553 (code B ref -1); Mon, 06 Jan 2025 20:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 20:08:04 +0000 Original-Received: from localhost ([127.0.0.1]:40222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUtON-0008Cr-PS for submit@debbugs.gnu.org; Mon, 06 Jan 2025 15:08:04 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:55124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUtOM-0008C9-6l for submit@debbugs.gnu.org; Mon, 06 Jan 2025 15:08:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUtOD-0000Na-Bn for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:07:53 -0500 Original-Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUtOA-00048g-5A for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2025 15:07:52 -0500 Original-Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 92E722594B; Mon, 6 Jan 2025 21:07:35 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3qeRuywPNRtq; Mon, 6 Jan 2025 21:07:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1736194050; bh=yZwXsqjZTDhmDHRD9msZ+CtDnhipEbtTj0M00JKMeoA=; h=From:To:Cc:Subject:Date; b=lmuvco3Eb0X0vzMB9DvVtFdDQJveDomChV8siRQItZo0W5uFMBSOw1EogqR2Ovg5u lkiWgRPI6Uv7iZRj3jk9X1sYIdB9STHdtDPrEk9R98+/45v3A1nUwMv+SY1wLv5U58 wW2ZQ1R4aU8VObgP1KJTMP27n6uIGnZpXfkor2nS5kYwz05Zb3q/XAQdkhtGKfpL8U rWmvYAy1I58WqsdhDH/MaJD4UROpXZUIbS3SfqnWB0GtZtzR8j7eh4zGaHlIPJ474e ueQZFkpA/Vrn94VoP59EBi0bwjPcscBTEnQvdUrzTiJ9jlGiA1Q+LBQOJJyIdIN2MN nEDUi7vLUk+XQ== Received-SPF: pass client-ip=178.21.23.139; envelope-from=gabrielsantosdesouza@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298695 Archived-At: --=-=-= Content-Type: text/plain Greetings, I discovered this mode through a blog post from Sacha: And I really liked it. Though, I felt that it was missing something: Some keybinds for navigation besides C-n and C-p, like those found in other read-only modes, such as dired-mode. This patch binds the following keys in `image-dired-thumbnail-mode-map': - "f" :: `image-dired-forward-image' - "b" :: `image-dired-backward-image' - "n" :: `image-dired-next-line' - "p" :: `image-dired-previous-line' - "a" :: `image-dired-move-beginning-of-line' - "e" :: `image-dired-move-end-of-line' These keys are currently unused in the mode. Regards, -- Gabriel Santos --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-image-dired--Add-extra-keybinds-for-navigation.patch Content-Description: [PATCH] image-dired: Add extra keybinds for navigation >From 8f7a1234ce7642f587e435347bf7ba22b397ce18 Mon Sep 17 00:00:00 2001 From: Gabriel Santos Date: Mon, 6 Jan 2025 16:56:31 -0300 Subject: [PATCH] image-dired: Add extra keybinds for navigation * lisp/image/image-dired.el (image-dired-thumbnail-mode-map): Bind previously unused keys for alternative navigation. --- lisp/image/image-dired.el | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 71c272e4388..b35199c60d4 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -944,6 +944,15 @@ You probably want to use this together with (defvar-keymap image-dired-thumbnail-mode-map :doc "Keymap for `image-dired-thumbnail-mode'." + + ;; Regular navigation + "f" #'image-dired-forward-image + "b" #'image-dired-backward-image + "n" #'image-dired-next-line + "p" #'image-dired-previous-line + "a" #'image-dired-move-beginning-of-line + "e" #'image-dired-move-end-of-line + "d" #'image-dired-flag-thumb-original-file "" #'image-dired-flag-thumb-original-file "m" #'image-dired-mark-thumb-original-file -- 2.47.1 --=-=-=--