From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: battery.el: Rename display-battery-mode to battery-mode? Date: Thu, 04 Aug 2005 19:28:48 +0300 Organization: JURTA Message-ID: <87mznxpt9e.fsf@jurta.org> References: <87pssu42bf.fsf@xs4all.nl> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1123174027 24633 80.91.229.2 (4 Aug 2005 16:47:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Aug 2005 16:47:07 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 04 18:47:05 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E0irT-0005SK-Bt for ged-emacs-devel@m.gmane.org; Thu, 04 Aug 2005 18:46:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E0iuH-00026N-Ij for ged-emacs-devel@m.gmane.org; Thu, 04 Aug 2005 12:49:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E0isC-0000e3-EH for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:47:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E0is4-0000aC-8k for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:47:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E0is1-0000V9-66 for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:47:01 -0400 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E0ipq-000809-NL for emacs-devel@gnu.org; Thu, 04 Aug 2005 12:44:46 -0400 Original-Received: from mail.neti.ee (80-235-42-219-dsl.mus.estpak.ee [80.235.42.219]) by Relayhost2.neti.ee (Postfix) with ESMTP id BA13D2025 for ; Thu, 4 Aug 2005 19:31:26 +0300 (EEST) Original-To: emacs-devel@gnu.org In-Reply-To: (Reiner Steib's message of "Thu, 04 Aug 2005 17:54:35 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41492 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41492 >>> I tried to enable battery-mode on my notebook using `M-x battery- >>> TAB' but I got "No match". Eventually I found >>> `display-battery-mode' in `battery.el'. Shouldn't the name of the >>> minor mode read `battery-mode' instead of `display-battery-mode'? >> >> Agreed. > > (In the meantime I saw that there's one similarly named (interactive) > command `display-time-mode'.) > >>> +(define-obsolete-function-alias 'display-battery-mode 'battery-mode "22.1") I suspect the name `display-battery-mode' was created to be similar to `display-time-mode' which displays additional information in the mode line as well. I suggest to create a valid alias `display-battery-mode' for renamed `battery-mode' instead of declaring it obsolete (i.e. to use `defalias' instead of `define-obsolete-function-alias'). Maybe, you also need to create a variable alias `display-battery-mode' for `battery-mode' because `define-minor-mode' creates a global variable. -- Juri Linkov http://www.jurta.org/emacs/