From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
Michael Cadilhac <michael.cadilhac-@t-lrde.epita.fr>,
emacs-devel@gnu.org
Subject: Re: File modes facilities.
Date: Fri, 21 Oct 2005 11:07:54 -0400 [thread overview]
Message-ID: <87mzl2kiyt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m34q7b3zb0.fsf@kfs-l.imdomain.dk> (Kim F. Storm's message of "Fri, 21 Oct 2005 13:05:39 +0200")
>> Agreed. I actually firmly believe that we should be able to provide
>> elisp code for the interactive spec of a C function.
> The previous patch I posted was completely untested, and didn't compile.
> Here is a better patch:
> *** data.c 19 Sep 2005 00:24:45 +0200 1.254
> --- data.c 21 Oct 2005 13:04:24 +0200
> ***************
> *** 787,793 ****
> if (SUBRP (fun))
> {
> if (XSUBR (fun)->prompt)
> ! return list2 (Qinteractive, build_string (XSUBR (fun)->prompt));
> }
> else if (COMPILEDP (fun))
> {
> --- 787,801 ----
> if (SUBRP (fun))
> {
> if (XSUBR (fun)->prompt)
> ! {
> ! Lisp_Object spec;
> ! if (XSUBR (fun)->prompt[0] != '#')
> ! return list2 (Qinteractive, build_string (XSUBR (fun)->prompt));
> !
> ! if ((spec = Fget (intern (XSUBR (fun)->symbol_name), Qinteractive),
> ! !NILP (spec)))
> ! return list2 (Qinteractive, spec);
> ! }
> }
> else if (COMPILEDP (fun))
> {
That sounds great, except I think it's important to be able to override in
elisp a previous interactive spec provided by C code.
Stefan
PS: Also I'd move the "spec = ..." out of the if.
next prev parent reply other threads:[~2005-10-21 15:07 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 20:09 File modes facilities Michael Cadilhac
2005-10-19 20:35 ` Stefan Monnier
2005-10-19 21:28 ` Michael Cadilhac
2005-10-19 22:19 ` Nick Roberts
2005-10-19 22:44 ` Michael Cadilhac
2005-10-19 22:48 ` Kim F. Storm
2005-10-19 22:57 ` Edward O'Connor
2005-10-19 23:00 ` Michael Cadilhac
2005-10-20 9:04 ` Eli Zaretskii
2005-10-20 10:41 ` Michael Cadilhac
2005-10-20 11:51 ` Romain Francoise
2005-10-20 12:41 ` Eli Zaretskii
2005-10-20 14:18 ` Michael Cadilhac
2005-10-20 16:15 ` Stefan Monnier
2005-10-20 22:16 ` Kim F. Storm
2005-10-21 3:21 ` Stefan Monnier
2005-10-21 8:44 ` Andreas Schwab
2005-10-21 12:59 ` Michael Cadilhac
2005-10-21 14:14 ` Miles Bader
2005-10-21 14:43 ` Kim F. Storm
2005-10-21 16:42 ` Michael Cadilhac
2005-10-21 22:19 ` Richard M. Stallman
2005-10-24 14:02 ` Kim F. Storm
2005-10-24 14:16 ` David Kastrup
2005-10-24 16:02 ` Andreas Schwab
2005-10-24 21:00 ` Kim F. Storm
2005-10-24 14:46 ` Stefan Monnier
2005-10-24 22:14 ` Kim F. Storm
2005-10-24 23:02 ` Stefan Monnier
2005-10-25 8:51 ` Kim F. Storm
2005-10-25 20:29 ` Richard M. Stallman
2005-10-25 15:58 ` Richard M. Stallman
2005-10-25 21:34 ` Kim F. Storm
2005-10-26 8:52 ` Kim F. Storm
2005-10-27 1:31 ` Richard M. Stallman
2005-10-27 1:29 ` Richard M. Stallman
2005-10-21 10:58 ` Kim F. Storm
2005-10-21 11:05 ` Kim F. Storm
2005-10-21 15:07 ` Stefan Monnier [this message]
2005-10-21 17:51 ` Richard M. Stallman
2005-10-21 18:43 ` Stefan Monnier
2005-10-22 4:18 ` Richard M. Stallman
2005-10-22 5:39 ` Drew Adams
2005-10-22 6:17 ` Miles Bader
2005-10-22 6:32 ` Drew Adams
2005-10-22 7:33 ` Miles Bader
2005-10-22 7:45 ` Drew Adams
2005-10-23 18:05 ` Stefan Monnier
2005-10-23 18:27 ` Drew Adams
2005-10-24 13:37 ` Richard M. Stallman
2005-10-24 13:40 ` Stefan Monnier
2005-10-24 16:41 ` Drew Adams
2005-10-24 16:59 ` Stefan Monnier
2005-10-24 17:13 ` Drew Adams
2005-10-20 23:38 ` Richard M. Stallman
2005-10-21 0:58 ` Michael Cadilhac
2005-10-21 1:06 ` Miles Bader
2005-10-21 1:24 ` Michael Cadilhac
2005-10-21 17:51 ` Richard M. Stallman
2005-10-23 23:42 ` Michael Cadilhac
2005-10-24 14:09 ` Kim F. Storm
2005-10-25 15:58 ` Richard M. Stallman
2005-10-20 1:42 ` Kevin Ryde
2005-10-20 2:01 ` Miles Bader
2005-10-20 7:12 ` Michael Cadilhac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mzl2kiyt.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.cadilhac-@t-lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.