From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Remove mouse-face in Occur buffers Date: Tue, 01 Nov 2005 11:17:32 +0200 Organization: JURTA Message-ID: <87mzkou617.fsf@jurta.org> References: <87br19nzk1.fsf@jurta.org> <87zmosceb3.fsf@jurta.org> <87hdayjjq8.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1130845899 20060 80.91.229.2 (1 Nov 2005 11:51:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 1 Nov 2005 11:51:39 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 01 12:51:34 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EWueE-0004P9-D7 for ged-emacs-devel@m.gmane.org; Tue, 01 Nov 2005 12:49:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EWueB-0003AB-L7 for ged-emacs-devel@m.gmane.org; Tue, 01 Nov 2005 06:49:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EWtnZ-0006vF-Oz for emacs-devel@gnu.org; Tue, 01 Nov 2005 05:55:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EWtnO-0006q8-7D for emacs-devel@gnu.org; Tue, 01 Nov 2005 05:55:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EWsYe-00009t-Ai for emacs-devel@gnu.org; Tue, 01 Nov 2005 04:35:57 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EWsYe-0002iB-9A for emacs-devel@gnu.org; Tue, 01 Nov 2005 04:35:56 -0500 Original-Received: from mail.neti.ee (80-235-34-45-dsl.mus.estpak.ee [80.235.34.45]) by Relayhost1.neti.ee (Postfix) with ESMTP id F3D23C802; Tue, 1 Nov 2005 11:36:07 +0200 (EET) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Mon, 31 Oct 2005 12:14:39 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45231 Archived-At: >> And it also servers as the default value of the `keep-props' >> argument (which before this patch was unconditionally non-nil). > > Ok, but then these checks in occur-accumulate-lines and occur-engine > seems superfluous: > >> (if (fboundp 'jit-lock-fontify-now) >> (jit-lock-fontify-now beg end))) >> (push >> ! (if (and keep-props (not (eq occur-excluded-properties t))) > > Just test keep-props here (it is nil if occur-excluded-properties = t. I added this double test intentionally, because someone might call `occur-engine' directly with `keep-props'=t, and at the same time `occur-excluded-properties' may have the default value t. In this case `remove-list-of-text-properties' will fail. Why I suspect that someone already might have code to call `occur-engine' directly is because so far the value for keeping text properties was hard-coded in `occur-1' with the value t (and I recall that at some moment it was hard-coded with nil), and how someone can customize this behavior other than calling `occur-engine' directly? -- Juri Linkov http://www.jurta.org/emacs/