From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Bug, probably related to Custom Themes. Date: Wed, 21 Dec 2005 13:31:34 -0500 Message-ID: <87mziuqp2x.fsf@stupidchicken.com> References: <200512210254.jBL2sj814876@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1135192864 27070 80.91.229.2 (21 Dec 2005 19:21:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2005 19:21:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 21 20:21:01 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ep9Te-0004Qc-5m for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2005 20:18:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ep9Ub-00008f-Nz for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2005 14:19:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ep8lS-0006uE-67 for emacs-devel@gnu.org; Wed, 21 Dec 2005 13:32:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ep8lL-0006rS-AH for emacs-devel@gnu.org; Wed, 21 Dec 2005 13:32:36 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ep8lJ-0006qg-NZ for emacs-devel@gnu.org; Wed, 21 Dec 2005 13:32:29 -0500 Original-Received: from [18.19.6.82] (helo=localhost.localdomain) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ep8oe-0000Kw-Op for emacs-devel@gnu.org; Wed, 21 Dec 2005 13:35:56 -0500 Original-Received: by localhost.localdomain (Postfix, from userid 1000) id 931671208D3; Wed, 21 Dec 2005 13:31:34 -0500 (EST) Original-To: Luc Teirlinck In-Reply-To: <200512210254.jBL2sj814876@raven.dms.auburn.edu> (Luc Teirlinck's message of "Tue, 20 Dec 2005 20:54:45 -0600 (CST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48161 Archived-At: Luc Teirlinck writes: > I assume that `inhibit-splash-screen' is at its standard setting (nil). > Toggle. Save for future sessions. Erase Customization. Result: > > (custom-reset-variables > '(inhibit-splash-screen nil)) > > is written into one's Custom file, just before the > custom-set-variables form. First of all, I do not know what those > lines are trying to accomplish, but what we just did is supposed to be > a no-op. Therefore if that code does _anything_, it is a bug. Why is it a bug? You did click on "Save for future sessions", which writes the customizations to .emacs. The tooltip for "Erase Customization" says "Un-customize all values in this buffer" (i.e., the Custom buffer). I wouldn't expect this to write to .emacs. > If it does nothing, why is it there? If you mean the "Erase Customization" button, I assume it's to reset all the items in the Custom buffer to their default (uncustomized) values. This does not imply making them take effect (that's what "Set For Current Session" and "Save for Future Sessions" is for.) On the other hand, it's not clear to me what the "Reset to Current" button is supposed to do. I'm guessing it resets items to values that may be changed outside of Customize. I don't think this serves much purpose except to confuse newbies, who wouldn't be changing stuff outside Customize anyway. Probably "Erase Customization" should be renamed "Reset to Default". > The following bug is a regression. It does not occur in Emacs 21.3. In Emacs 21.3, Erase Customization doesn't write to .emacs either. (I really don't see how this issue is related to Custom Themes, btw.) It would be nice if Custom is smart enough to detect when a variable is being set back to its default value, and omit that variable in custom-set-variables. But this would be a new feature, not a bugfix.