From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Parsing URL attributes - url-mailto, url-imap, url-ldap broken? Date: Sun, 15 Apr 2007 12:50:58 -0400 Message-ID: <87mz19twct.fsf@stupidchicken.com> References: <87ps69tz33.fsf@x3y2z1.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1176655879 6860 80.91.229.12 (15 Apr 2007 16:51:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 15 Apr 2007 16:51:19 +0000 (UTC) Cc: Diane Murray , emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 15 18:51:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hd7wV-0002Xx-RF for ged-emacs-devel@m.gmane.org; Sun, 15 Apr 2007 18:51:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hd811-00079H-HN for ged-emacs-devel@m.gmane.org; Sun, 15 Apr 2007 12:55:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hd80y-00077t-Ve for emacs-devel@gnu.org; Sun, 15 Apr 2007 12:55:49 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hd80y-00075R-4e for emacs-devel@gnu.org; Sun, 15 Apr 2007 12:55:48 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hd7wR-0000E0-Kh; Sun, 15 Apr 2007 12:51:07 -0400 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l3FGp6E9008281; Sun, 15 Apr 2007 12:51:06 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l3FGowsG016282; Sun, 15 Apr 2007 12:50:59 -0400 (EDT) Original-Received: from localhost (SYDNEYPACIFIC-SEVEN-FIFTY-SEVEN.MIT.EDU [18.95.7.246]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l3FGowQ5025323; Sun, 15 Apr 2007 12:50:58 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1Hd7wI-0002g4-00; Sun, 15 Apr 2007 12:50:58 -0400 In-Reply-To: (Richard Stallman's message of "Sun\, 15 Apr 2007 09\:59\:30 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.97 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69459 Archived-At: Richard Stallman writes: > Is anyone working on this? AFAICT, Diane Murray's analysis is correct. The 2006-10-09 change was intended to parse http query strings better, but url-http apparently doesn't use the result; on the other hand, url-mailto and other parts of url that depended on the old behavior got broken. Since Magnus Henoch has not responded, I went ahead and reverted the patch that caused this problem. After the release, we can re-apply the patch, and adapt url-mailto etc to the new behavior of url-generic-parse-url. > Date: Thu, 12 Apr 2007 17:02:56 +0200 > From: Diane Murray > To: emacs-devel@gnu.org > Subject: Parsing URL attributes - url-mailto, url-imap, url-ldap broken? > > I just noticed that `url-mailto' doesn't parse URLs with query > arguments like it used to. If I call > (url-retrieve-synchronously "mailto:ml+atest@x3y2z1.net?subject=testing") > the word "testing" should be inserted in the Subject field, but it > isn't. In Emacs CVS of 2006-09-19 it does that. I'm assuming after > because of the following changes, now it doesn't: > > 2006-10-09 Magnus Henoch > > * url-parse.el (url-generic-parse-url): Handle URLs with empty > path component and non-empty query component. Untangle path, > query and fragment parsing code. Add references to RFC 3986 in > comments. > (url-recreate-url-attributes): Start query string with "?", not ";". > > I think `url-imap' and `url-ldap' won't work correctly either, from > what I've seen in the source code. > > Since the change was probably made to parse http query strings better, > and there is no such use of url-attributes in url-http.el, I believe > it should be safe to somehow revert to the old way, since many of the > other url scheme files depend on that way of doing things.