From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Minibuffer default values list Date: Sat, 24 Nov 2007 19:54:45 +0200 Organization: JURTA Message-ID: <87myt3zk65.fsf@jurta.org> References: <87zlycuhrd.fsf@jurta.org> <87hckbecc0.fsf@jurta.org> <87prygxtot.fsf@jurta.org> <87hcjjkrgy.fsf@jurta.org> <87ir3u9r5s.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195927315 22654 80.91.229.12 (24 Nov 2007 18:01:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Nov 2007 18:01:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 24 19:02:03 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IvzKM-0005s5-Hr for ged-emacs-devel@m.gmane.org; Sat, 24 Nov 2007 19:02:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvzK8-00015d-2o for ged-emacs-devel@m.gmane.org; Sat, 24 Nov 2007 13:01:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IvzI4-0006zQ-UF for emacs-devel@gnu.org; Sat, 24 Nov 2007 12:59:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IvzI1-0006ur-7Y for emacs-devel@gnu.org; Sat, 24 Nov 2007 12:59:38 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvzI0-0006uY-Os for emacs-devel@gnu.org; Sat, 24 Nov 2007 12:59:36 -0500 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IvzHr-0005bb-5m; Sat, 24 Nov 2007 12:59:27 -0500 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1IvzHn-000C1f-8y; Sat, 24 Nov 2007 19:59:24 +0200 In-Reply-To: (Richard Stallman's message of "Thu, 22 Nov 2007 23:35:53 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-Scanner-Signature: 5a5a69023ff65cd0bc9708389afc5997 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1826 [Nov 24 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 19 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84067 Archived-At: > If you don't want loading mailcap.el on M-! then what do you think about > loading mailcap.el only when the user types M-n in the shell command's > minibuffer? > > That is an interesting approach. Below is a patch that implements this approach. It adds a new variable `goto-history-element-pre-hook' run at the beginning of `goto-history-element'. And `shell-command' binds it to a function that after typing e.g. `M-n M-n' and going to the second default value (the first element is a static value set to the current file name) adds more commands extracted from mailcap to `minibuffer-default'. `dired-read-shell-command' below does the same. Index: lisp/simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.889 diff -c -r1.889 simple.el *** lisp/simple.el 15 Nov 2007 16:42:43 -0000 1.889 --- lisp/simple.el 24 Nov 2007 17:54:00 -0000 *************** *** 1298,1307 **** --- 1298,1311 ---- (defvar minibuffer-temporary-goal-position nil) + (defvar goto-history-element-pre-hook nil + "*List of functions run by `goto-history-element' before changing history position.") + (defun goto-history-element (nabs) "Puts element of the minibuffer history in the minibuffer. The argument NABS specifies the absolute history position." (interactive "p") + (run-hooks 'goto-history-element-pre-hook) (let ((minimum (if minibuffer-default (- (if (listp minibuffer-default) (length minibuffer-default) *************** *** 1962,1971 **** In an interactive call, the variable `shell-command-default-error-buffer' specifies the value of ERROR-BUFFER." ! (interactive (list (read-from-minibuffer "Shell command: " ! nil nil nil 'shell-command-history) ! current-prefix-arg ! shell-command-default-error-buffer)) ;; Look for a handler in case default-directory is a remote file name. (let ((handler (find-file-name-handler (directory-file-name default-directory) --- 1966,1988 ---- In an interactive call, the variable `shell-command-default-error-buffer' specifies the value of ERROR-BUFFER." ! (interactive ! (let* ((filename ! (if buffer-file-name (file-relative-name buffer-file-name))) ! (default filename) ! (minibuffer-default-set nil) ! (goto-history-element-pre-hook ! (cons (lambda () ! (when (and (null minibuffer-default-set) (< nabs -1)) ! (setq minibuffer-default ! (cons filename (dired-read-shell-command-default ! (list filename)))) ! (setq minibuffer-default-set t))) ! goto-history-element-pre-hook))) ! (list (read-from-minibuffer "Shell command: " nil nil nil ! 'shell-command-history default) ! current-prefix-arg ! shell-command-default-error-buffer))) ;; Look for a handler in case default-directory is a remote file name. (let ((handler (find-file-name-handler (directory-file-name default-directory) Index: lisp/dired-aux.el =================================================================== RCS file: /sources/emacs/emacs/lisp/dired-aux.el,v retrieving revision 1.160 diff -c -r1.160 dired-aux.el *** lisp/dired-aux.el 22 Nov 2007 13:49:34 -0000 1.160 --- lisp/dired-aux.el 24 Nov 2007 17:54:25 -0000 *************** *** 517,528 **** ;;ARG is the prefix arg and may be used to indicate in the prompt which ;; files are affected. ;;This is an extra function so that you can redefine it, e.g., to use gmhist." ! (dired-mark-pop-up ! nil 'shell files ! (function read-string) ! (format prompt (dired-mark-prompt arg files)) ! nil 'shell-command-history ! (dired-read-shell-command-default files))) ;; The in-background argument is only needed in Emacs 18 where ;; shell-command doesn't understand an appended ampersand `&'. --- 517,534 ---- ;;ARG is the prefix arg and may be used to indicate in the prompt which ;; files are affected. ;;This is an extra function so that you can redefine it, e.g., to use gmhist." ! (let ((minibuffer-default-set nil) ! (goto-history-element-pre-hook ! (cons (lambda () ! (when (and (null minibuffer-default-set) (< nabs 0)) ! (setq minibuffer-default (dired-read-shell-command-default files) ! minibuffer-default-set t))) ! goto-history-element-pre-hook))) ! (dired-mark-pop-up ! nil 'shell files ! (function read-string) ! (format prompt (dired-mark-prompt arg files)) ! nil 'shell-command-history))) ;; The in-background argument is only needed in Emacs 18 where ;; shell-command doesn't understand an appended ampersand `&'. -- Juri Linkov http://www.jurta.org/emacs/