23.0.50; latest change to blackbox.el breaks the game

23.0.50; latest change to blackbox.el breaks the game

[Sven Joachim]

The following change in revision 1.26 of blackbox.el causes breakage:

,----
| 2007-10-21  Dan Nicolaescu  <dann@ics.uci.edu>
| 
| 	* play/blackbox.el (bb-up, bb-down): Use forward-line.
`----

After this change, bb-up and bb-down move to the beginning of the line,
no matter where point was before.  That renders blackbox pretty much
unplayable. :-(


In GNU Emacs 23.0.50.5 (i686-pc-linux-gnu, GTK+ Version 2.12.1)
 of 2007-12-01 on debian
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-undo-mode: t
  display-time-mode: t
  auto-image-file-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  temp-buffer-resize-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x k <return> M-x <up> <return> <right> <right> <right> 
<right> <right> <right> <down> C-h k <down> C-x o <tab> 
<return> <down> <down> <down> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> C-h 
f <return> C-h f p r e v i <backspace> <backspace> 
<backspace> <backspace> <backspace> n e x t <tab> l 
i <tab> <return> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> C-c l C-g C-x 1 C-c l b l a 
c k b o x . e l <return> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<up> <return> C-x 1 C-x v l C-x o C-x v l C-x + <next> 
<prior> <prior> <next> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> C-x o C-u C-x v = <return> <return> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <up> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> C-x 1 M-x g n u s <return> <down> <down> SPC 
q SPC q SPC q SPC q M-x r e p o r t . <backspace> - 
e m <tab> <return>

Recent messages:
Fetching headers for nntp+news.gnus.org:gnu.emacs.bug...done
Generating summary...done
Retrieving newsgroup: gmane.linux.debian.devel.bugs.general...
Opening nntp server on news.gmane.org...done
Fetching headers for gmane.linux.debian.devel.bugs.general...done
Generating summary...done
Retrieving newsgroup: gmane.linux.debian.user.german...
Fetching headers for gmane.linux.debian.user.german...done
Generating summary...done
No more unread newsgroups

Re: 23.0.50; latest change to blackbox.el breaks the game

[martin rudalics]

> The following change in revision 1.26 of blackbox.el causes breakage:
> 
> ,----
> | 2007-10-21  Dan Nicolaescu  <dann@ics.uci.edu>
> | 
> | 	* play/blackbox.el (bb-up, bb-down): Use forward-line.
> `----
> 
> After this change, bb-up and bb-down move to the beginning of the line,
> no matter where point was before.  That renders blackbox pretty much
> unplayable. :-(

I've checked in a fix, please retry.

Re: 23.0.50; latest change to blackbox.el breaks the game

[Sven Joachim]

On 2007-12-01 10:08 +0100, martin rudalics wrote:

> I've checked in a fix, please retry.

Works well, thanks for the fast reply.

Cheers,
       Sven