From: D. Goel <deego@gnufans.org>
To: emacs-devel@gnu.org , Dave Goel <deego3@gmail.com>
Subject: Fixing numerous `message' bugs..
Date: Wed, 05 Dec 2007 19:14:47 -0500 [thread overview]
Message-ID: <87myso8yrs.fsf@marie.gnufans.net> (raw)
The emacs source code is littered with thousands of buggy calls to
`message'. Here is an example of such a structure:
(message
(if foo
nil
(if bar "abc"
(concat "def" filename))))
This example will lead to an error if the filename has %s in it.
At the same time, the simplistic fix of replacing (message by (message
"%s" would be incorrect because if foo is true, the coder wanted
(message nil), and not (message "%s" nil).
The appropriate fix to this would be
(let ((arg ((rest-of-the-code))))
(if (null arg)
(message nil)
(message "%s" arg)))
^^^ This fix will have to be repeated thousands of time as I go
through the source code.
It would rather make much more sense to code this fix into a little
function:
(defun msg (arg)
(if (null arg)
(message nil)
(message (format "%s" arg))))
Then, I simply have to replace buggy calls to `message' with `msg'
----
.. this new function can be further improved to be more general, so
that develepors can simply start preferring the new msg if they like -
(defun msg (&rest args)
(cond
((null args) (message nil))
((null (car args) (message nil)))
((= (length args) 1) (message "%s" (car args)))
(apply 'message args)))
I would like to add `msg' to simple.el, and replace buggy `message'
calls by `msg'. Can you please confirm or comment?
((My correct email is now deego3@gmail.com, please cc there as well;
emacs-devel seems to send those messages to spam, so I am emailing
from my older gnufans address. If an admin sees this, can you please
unblock my other email to emacs-devel sent earlier today about a
bugfix I made to find-func.el? thanks.)
- deego (Deepak Goel)
next reply other threads:[~2007-12-06 0:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 0:14 D. Goel [this message]
2007-12-06 10:56 ` Fixing numerous `message' bugs David Kastrup
2007-12-06 14:36 ` Dave Goel
2007-12-06 19:26 ` Glenn Morris
2007-12-06 19:34 ` Dave Goel
2007-12-06 20:21 ` Johan Bockgård
2007-12-07 5:28 ` Glenn Morris
2007-12-07 15:52 ` Dave Goel
2007-12-06 15:53 ` Stefan Monnier
2007-12-06 16:01 ` Dave Goel
2007-12-06 16:49 ` Stefan Monnier
2007-12-06 16:58 ` David Kastrup
2007-12-06 17:19 ` David Kastrup
2007-12-07 17:17 ` Richard Stallman
2007-12-07 17:37 ` David Kastrup
2007-12-07 17:17 ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman
2007-12-07 17:24 ` David Kastrup
2007-12-07 18:00 ` Dave Goel
2007-12-07 18:38 ` Stefan Monnier
2007-12-08 0:56 ` Glenn Morris
2007-12-08 2:21 ` Stefan Monnier
2007-12-08 10:55 ` David Kastrup
2007-12-08 19:15 ` Richard Stallman
2007-12-10 17:41 ` Dave Goel
2007-12-10 18:04 ` Jason Rumney
2007-12-10 19:05 ` Dave Goel
2007-12-10 19:56 ` Andreas Schwab
2007-12-10 20:31 ` Dave Goel
2007-12-10 21:19 ` David Kastrup
2007-12-10 22:44 ` Dave Goel
2007-12-10 23:02 ` David Kastrup
2007-12-08 19:15 ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87myso8yrs.fsf@marie.gnufans.net \
--to=deego@gnufans.org \
--cc=deego3@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.