From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: doc-view support for bookmark.el Date: Wed, 26 Dec 2007 09:22:50 +0100 Message-ID: <87myrxg90l.fsf@member.fsf.org> References: <8763yn3v07.fsf@member.fsf.org> <87prwu3kg0.fsf@member.fsf.org> <87prwu77ug.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198657392 24515 80.91.229.12 (26 Dec 2007 08:23:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Dec 2007 08:23:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 26 09:23:26 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7RXs-0007jV-GO for ged-emacs-devel@m.gmane.org; Wed, 26 Dec 2007 09:23:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7RXX-0004V4-ME for ged-emacs-devel@m.gmane.org; Wed, 26 Dec 2007 03:22:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7RXS-0004UD-04 for emacs-devel@gnu.org; Wed, 26 Dec 2007 03:22:54 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7RXQ-0004Tu-IR for emacs-devel@gnu.org; Wed, 26 Dec 2007 03:22:53 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7RXQ-0004Tr-DL for emacs-devel@gnu.org; Wed, 26 Dec 2007 03:22:52 -0500 Original-Received: from out4.smtp.messagingengine.com ([66.111.4.28]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J7RXQ-0005el-5P for emacs-devel@gnu.org; Wed, 26 Dec 2007 03:22:52 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id F02F180A25 for ; Wed, 26 Dec 2007 03:22:51 -0500 (EST) Original-Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 26 Dec 2007 03:22:51 -0500 X-Sasl-enc: ZhJ8vL4ZaVd04zKaMlCvxLB2NC8Zdz1cPn6nHk+e7f2/ 1198657371 Original-Received: from baldur (dslb-084-063-053-224.pools.arcor-ip.net [84.63.53.224]) by mail.messagingengine.com (Postfix) with ESMTP id 4EE173F2C for ; Wed, 26 Dec 2007 03:22:51 -0500 (EST) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "Tue, 25 Dec 2007 18:07:32 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85471 Archived-At: Stefan Monnier writes: Hi Stefan, >> Do you think it's ok and I should install it? > > Looks good from a cursory glance at it, although the repetition of all > those bookmark-get-handler + if + funcall is begging for some > redundancy-reduction. Yes, that came into my mind shortly after I've sent the patch. I'll extract that into it's own function and install it then. Bye, Tassilo