all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ralf Angeli <angeli@caeruleus.net>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Patch for focus-frame use in RefTeX (was: declare-function in files from Gnus (hashcash.el, imap.el))
Date: Sat, 05 Jan 2008 14:13:50 +0100	[thread overview]
Message-ID: <87myrko1o1.fsf@photon.caeruleus.net> (raw)
In-Reply-To: <200712011634.lB1GYCkr018222@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Sat, 01 Dec 2007 08:34:07 -0800")

* Dan Nicolaescu (2007-12-01) writes:

> Talking about RefTeX, can you please fix this warning:
>
> In reftex-make-separate-toc-frame:
> reftex-toc.el:998:35:Warning: `focus-frame' is an obsolete function (as
> of  Emacs 22.1); it does nothing.

Okay, I saw that Glenn went ahead and fixed this in the Emacs trunk.
I've just committed a slightly different change in the RefTeX
repository.  Please apply the following patch to reftex-toc.el in the
Emacs repository in order to synchronize both files with respect to this
part of the code.

2008-01-05  Ralf Angeli  <angeli@caeruleus.net>

	* textmodes/reftex-toc.el (reftex-make-separate-toc-frame):
	Simplify selection of frame focusing function.


--- reftex-toc.el.~1.40.~	2007-12-08 02:02:19.000000000 +0100
+++ reftex-toc.el	2008-01-05 14:04:15.000000000 +0100
@@ -995,10 +995,11 @@
       (select-frame current-toc-frame)
       (switch-to-buffer "*toc*")
       (select-frame current-frame)
-      (if (fboundp 'x-focus-frame) (x-focus-frame current-frame)
-        ;; focus-frame has done nothing in Emacs since at least v21.
-        (if (featurep 'xemacs)
-            (if (fboundp 'focus-frame) (focus-frame current-frame))))
+      (cond ((fboundp 'x-focus-frame)
+	     (x-focus-frame current-frame))
+	    ((and (featurep 'xemacs) ; `focus-frame' is a nop in Emacs.
+		  (fboundp 'focus-frame))
+	     (focus-frame current-frame)))
       (select-window current-window)
       (when (eq reftex-auto-recenter-toc 'frame)
         (unless reftex-toc-auto-recenter-timer


-- 
Ralf

  parent reply	other threads:[~2008-01-05 13:13 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 22:56 declare-function in files from Gnus (hashcash.el, imap.el) Reiner Steib
2007-11-30 23:27 ` Glenn Morris
2007-12-01 18:35   ` Reiner Steib
2007-12-01 18:54     ` Dan Nicolaescu
2007-12-01 20:35       ` Glenn Morris
2007-12-01 20:40         ` Dan Nicolaescu
2007-12-01 21:50     ` Glenn Morris
2007-12-01  9:15 ` Ralf Angeli
2007-12-01 16:34   ` Dan Nicolaescu
2007-12-01 17:09     ` Ralf Angeli
2007-12-01 20:44       ` Stephen J. Turnbull
2006-12-02  0:01         ` Ralf Angeli
2007-12-02  0:33           ` Stephen J. Turnbull
2007-12-01 23:41       ` Richard Stallman
2006-12-01 23:58         ` Ralf Angeli
2007-12-02 21:26           ` Richard Stallman
2006-12-02 21:59             ` Ralf Angeli
2007-12-02 22:37               ` Dan Nicolaescu
2007-12-03 18:28                 ` Ralf Angeli
2007-12-03 23:12                 ` Reiner Steib
2007-12-03 23:40                   ` Dan Nicolaescu
2007-12-05 20:35                     ` Reiner Steib
2007-12-05 21:01                       ` Glenn Morris
2007-12-08 19:42                         ` Reiner Steib
2007-12-08 22:58                           ` Dan Nicolaescu
2007-12-09  2:20                             ` Glenn Morris
2007-12-09 20:10                               ` Austin Frank
2007-12-09 21:22                                 ` Reiner Steib
2007-12-04 16:55                   ` Richard Stallman
2007-12-02 20:07       ` Dan Nicolaescu
2008-01-05 13:13     ` Ralf Angeli [this message]
2007-12-01 21:42 ` syncing from Emacs to Gnus [was Re: declare-function in files from Gnus (hashcash.el, imap.el)] Glenn Morris
2007-12-01 23:22   ` syncing from Emacs to Gnus Reiner Steib
2007-12-02 14:56     ` Stefan Monnier
2007-12-02 18:39     ` Richard Stallman
2007-12-03  2:25       ` Stefan Monnier
2007-12-03 18:43         ` Richard Stallman
2007-12-03 18:59           ` Stefan Monnier
2007-12-06  2:12             ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87myrko1o1.fsf@photon.caeruleus.net \
    --to=angeli@caeruleus.net \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.