* Re: 23.0.50; Image support disabled by default?
[not found] <87sl0o5wtf.GNU\\\'s_Not_Unix!%yavor@gnu.org>
@ 2008-01-23 21:23 ` Adolfo De Unanue
2008-01-23 21:58 ` Yavor Doganov
0 siblings, 1 reply; 13+ messages in thread
From: Adolfo De Unanue @ 2008-01-23 21:23 UTC (permalink / raw)
To: emacs-devel
>
> 2008-01-23 Yavor Doganov <yavor <at> gnu.org> (tiny change)
>
> * configure.in: Use OPTION_DEFAULT_ON for xpm, jpeg, tiff,
> gif, png and rsvg.
Hi,
I modify the configure.in, so now the lib images are in ON (i.e.
OPTION_DEFAULT_ON) but I am getting the same response after
the ./compile. The same thing happens if I use ./configure --with-ljpeg
--with-ltiff etc...
Any ideas?
Adolfo
[...]
Where should the build process find the source code? /home/nano/software/emacs
What operating system and machine description files should Emacs use?
`s/gnu-linux.h' and `m/intel386.h'
What compiler should emacs be built with? gcc -g -O2
-Wno-pointer-sign
Should Emacs use the GNU version of malloc? yes
(Using Doug Lea's new malloc from the GNU C Library.)
Should Emacs use a relocating allocator for buffers? yes
Should Emacs use mmap(2) for buffer allocation? no
What window system should Emacs use? x11
What toolkit should Emacs use? GTK
Where do we find X Windows header files? Standard dirs
Where do we find X Windows libraries? Standard dirs
Does Emacs use -lXaw3d? no
Does Emacs use -lXpm? no
Does Emacs use -ljpeg? no
Does Emacs use -ltiff? no
Does Emacs use a gif library? no
Does Emacs use -lpng? no
Does Emacs use -lrsvg-2? no
Does Emacs use -lgpm? no
Does Emacs use X toolkit scroll bars? yes
[...]
The weird thing is I have libxaw3d, libxpm4 (3.5.6-3), libjpeg (6b-14),
libtiff (3.8.2-7),libungif (4.1.4-5), librsvg-2 (2.18.2-1) and libgpm
(1.19.6-25) installed! (Including the -dev)
What is the problem? Maybe I have to update all the libs? By the way I
am running a Ubuntu Gutsy.
^ permalink raw reply [flat|nested] 13+ messages in thread
* 23.0.50; Image support disabled by default?
@ 2008-01-23 16:30 Yavor Doganov
2008-01-23 16:44 ` Tom Tromey
2008-01-23 17:17 ` Jason Rumney
0 siblings, 2 replies; 13+ messages in thread
From: Yavor Doganov @ 2008-01-23 16:30 UTC (permalink / raw)
To: emacs-devel
This change
2008-01-23 Tom Tromey <tromey@redhat.com>
* configure.in (OPTION_DEFAULT_ON, OPTION_DEFAULT_OFF): New
macros.
(EMACS_ARG_Y, EMACS_ARG_N): Remove.
Update all users.
introduces a regression: if the user runs ./configure without
arguments, image support is disabled by default, so now one has to
explicitly specify the the various --with-foo options for all image
formats.
Was this intended or it happened by accident? I imagine that the
majority of the users want support for as many image formats as
possible.
2008-01-23 Yavor Doganov <yavor@gnu.org> (tiny change)
* configure.in: Use OPTION_DEFAULT_ON for xpm, jpeg, tiff,
gif, png and rsvg.
*** configure.in 23 яну 2008 12:04:23 +0200 1.497
--- configure.in 23 яну 2008 17:46:00 +0200
***************
*** 122,134 ****
with_x_toolkit=$val
])
! OPTION_DEFAULT_OFF([xpm],[use -lXpm for displaying XPM images])
! OPTION_DEFAULT_OFF([jpeg],[use -ljpeg for displaying JPEG images])
! OPTION_DEFAULT_OFF([tiff],[use -ltiff for displaying TIFF images])
! OPTION_DEFAULT_OFF([gif],[use -lgif (or -lungif) for displaying GIF images])
! OPTION_DEFAULT_OFF([png],[use -lpng for displaying PNG images])
OPTION_DEFAULT_OFF([gpm],[use -lgpm for mouse support on a GNU/Linux console])
! OPTION_DEFAULT_OFF([rsvg],[use -lrsvg-2 for displaying SVG images])
OPTION_DEFAULT_OFF([gtk],[use GTK (same as --with-x-toolkit=gtk)])
OPTION_DEFAULT_ON([toolkit-scroll-bars],[don't use Motif or Xaw3d scroll bars])
OPTION_DEFAULT_ON([xaw3d],[don't use Xaw3d])
--- 122,134 ----
with_x_toolkit=$val
])
! OPTION_DEFAULT_ON([xpm],[use -lXpm for displaying XPM images])
! OPTION_DEFAULT_ON([jpeg],[use -ljpeg for displaying JPEG images])
! OPTION_DEFAULT_ON([tiff],[use -ltiff for displaying TIFF images])
! OPTION_DEFAULT_ON([gif],[use -lgif (or -lungif) for displaying GIF images])
! OPTION_DEFAULT_ON([png],[use -lpng for displaying PNG images])
OPTION_DEFAULT_OFF([gpm],[use -lgpm for mouse support on a GNU/Linux console])
! OPTION_DEFAULT_ON([rsvg],[use -lrsvg-2 for displaying SVG images])
OPTION_DEFAULT_OFF([gtk],[use GTK (same as --with-x-toolkit=gtk)])
OPTION_DEFAULT_ON([toolkit-scroll-bars],[don't use Motif or Xaw3d scroll bars])
OPTION_DEFAULT_ON([xaw3d],[don't use Xaw3d])
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-23 16:30 Yavor Doganov
@ 2008-01-23 16:44 ` Tom Tromey
2008-01-23 17:17 ` Jason Rumney
1 sibling, 0 replies; 13+ messages in thread
From: Tom Tromey @ 2008-01-23 16:44 UTC (permalink / raw)
To: Yavor Doganov; +Cc: emacs-devel
>>>>> "Yavor" == Yavor Doganov <yavor@gnu.org> writes:
Yavor> Was this intended or it happened by accident? I imagine that the
Yavor> majority of the users want support for as many image formats as
Yavor> possible.
It was an accident. Sorry about that, I overlooked how the variable
test were written in this case.
Yavor> 2008-01-23 Yavor Doganov <yavor@gnu.org> (tiny change)
Yavor> * configure.in: Use OPTION_DEFAULT_ON for xpm, jpeg, tiff,
Yavor> gif, png and rsvg.
I think this should go in.
Tom
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-23 16:30 Yavor Doganov
2008-01-23 16:44 ` Tom Tromey
@ 2008-01-23 17:17 ` Jason Rumney
2008-01-23 17:21 ` Yavor Doganov
2008-01-23 18:40 ` Tom Tromey
1 sibling, 2 replies; 13+ messages in thread
From: Jason Rumney @ 2008-01-23 17:17 UTC (permalink / raw)
To: Yavor Doganov; +Cc: emacs-devel
Yavor Doganov wrote:
> ! OPTION_DEFAULT_ON([xpm],[use -lXpm for displaying XPM images])
> ! OPTION_DEFAULT_ON([jpeg],[use -ljpeg for displaying JPEG images])
> ! OPTION_DEFAULT_ON([tiff],[use -ltiff for displaying TIFF images])
> ! OPTION_DEFAULT_ON([gif],[use -lgif (or -lungif) for displaying GIF images])
> ! OPTION_DEFAULT_ON([png],[use -lpng for displaying PNG images])
> OPTION_DEFAULT_OFF([gpm],[use -lgpm for mouse support on a GNU/Linux console])
> ! OPTION_DEFAULT_ON([rsvg],[use -lrsvg-2 for displaying SVG images])
> OPTION_DEFAULT_OFF([gtk],[use GTK (same as --with-x-toolkit=gtk)])
>
Also GTK should be on by default. The whole change probably needs
reviewing, as it seems to either be based on a very old version of
configure.in or everything has been reversed.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-23 17:17 ` Jason Rumney
@ 2008-01-23 17:21 ` Yavor Doganov
2008-01-23 18:40 ` Tom Tromey
1 sibling, 0 replies; 13+ messages in thread
From: Yavor Doganov @ 2008-01-23 17:21 UTC (permalink / raw)
To: Jason Rumney; +Cc: emacs-devel
On Wed, Jan 23, 2008 at 05:17:39PM +0000, Jason Rumney wrote:
>> OPTION_DEFAULT_OFF([gtk],[use GTK (same as --with-x-toolkit=gtk)])
> Also GTK should be on by default.
It is on by default now; the above line is a bit misleading.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-23 17:17 ` Jason Rumney
2008-01-23 17:21 ` Yavor Doganov
@ 2008-01-23 18:40 ` Tom Tromey
2008-01-25 4:37 ` Glenn Morris
1 sibling, 1 reply; 13+ messages in thread
From: Tom Tromey @ 2008-01-23 18:40 UTC (permalink / raw)
To: Jason Rumney; +Cc: Yavor Doganov, emacs-devel
>>>>> "Jason" == Jason Rumney <jasonr@gnu.org> writes:
Jason> Also GTK should be on by default. The whole change probably
Jason> needs reviewing, as it seems to either be based on a very old
Jason> version of configure.in or everything has been reversed.
It is more that I just messed up and didn't realize how much code was
checking `$with_foo != no' while using the ostensible "default to yes"
macro.
Tom
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-23 18:40 ` Tom Tromey
@ 2008-01-25 4:37 ` Glenn Morris
2008-01-25 5:00 ` YAMAMOTO Mitsuharu
0 siblings, 1 reply; 13+ messages in thread
From: Glenn Morris @ 2008-01-25 4:37 UTC (permalink / raw)
To: Tom Tromey; +Cc: Yavor Doganov, emacs-devel, Jason Rumney
I tried to fix this. I'm still not convinced all the various options
have the same behaviour as they did before...
--with-gtk should not be of type ON by default, IMO, because it will
change behaviour. In order to get eg a Lucid toolkit, I'd have to use
--with-gtk=no --with-x-toolkit=lucid
to avoid an error about incompatible options. Currently I can just
specify a toolkit.
The default X toolkit is still gtk, even without --with-gtk being ON.
In fact, as a separate issue I'd like to suggest getting rid of the
--with-gtk option. The --with-x-toolkit option on its own allows for
all the choices, AFAIK, in a simpler fashion. No need to have two ways
to specify the same thing.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-25 4:37 ` Glenn Morris
@ 2008-01-25 5:00 ` YAMAMOTO Mitsuharu
2008-01-26 2:24 ` Glenn Morris
2008-01-27 22:20 ` Tom Tromey
0 siblings, 2 replies; 13+ messages in thread
From: YAMAMOTO Mitsuharu @ 2008-01-25 5:00 UTC (permalink / raw)
To: Glenn Morris; +Cc: Tom Tromey, Yavor Doganov, Jason Rumney, emacs-devel
>>>>> On Thu, 24 Jan 2008 23:37:04 -0500, Glenn Morris <rgm@gnu.org> said:
> I tried to fix this. I'm still not convinced all the various options
> have the same behaviour as they did before...
Setting CC on configure no longer works without `--without-gcc'.
CC='gcc -arch ppc64' ./configure --without-gcc
looks so strange.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-25 5:00 ` YAMAMOTO Mitsuharu
@ 2008-01-26 2:24 ` Glenn Morris
2008-01-26 4:55 ` Tom Tromey
2008-01-27 22:20 ` Tom Tromey
1 sibling, 1 reply; 13+ messages in thread
From: Glenn Morris @ 2008-01-26 2:24 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: Tom Tromey, Yavor Doganov, Jason Rumney, emacs-devel
YAMAMOTO Mitsuharu wrote:
> Setting CC on configure no longer works without `--without-gcc'.
>
> CC='gcc -arch ppc64' ./configure --without-gcc
>
> looks so strange.
That's clearly broken. This new DEFAULT_ON/OFF stuff has removed the
possibility that not specifying an option might be different from
explicitly saying yes/no (respectively).
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-26 2:24 ` Glenn Morris
@ 2008-01-26 4:55 ` Tom Tromey
2008-01-27 22:27 ` Tom Tromey
0 siblings, 1 reply; 13+ messages in thread
From: Tom Tromey @ 2008-01-26 4:55 UTC (permalink / raw)
To: Glenn Morris; +Cc: Yavor Doganov, Jason Rumney, YAMAMOTO Mitsuharu, emacs-devel
>>>>> "GM" == Glenn Morris <rgm@gnu.org> writes:
GM> YAMAMOTO Mitsuharu wrote:
>> Setting CC on configure no longer works without `--without-gcc'.
>>
>> CC='gcc -arch ppc64' ./configure --without-gcc
>>
>> looks so strange.
GM> That's clearly broken. This new DEFAULT_ON/OFF stuff has removed the
GM> possibility that not specifying an option might be different from
GM> explicitly saying yes/no (respectively).
I'm sorry about the breakage from this.
I will come up with a patch this weekend.
Tom
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: 23.0.50; Image support disabled by default?
2008-01-25 5:00 ` YAMAMOTO Mitsuharu
2008-01-26 2:24 ` Glenn Morris
@ 2008-01-27 22:20 ` Tom Tromey
1 sibling, 0 replies; 13+ messages in thread
From: Tom Tromey @ 2008-01-27 22:20 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: Glenn Morris, Yavor Doganov, Jason Rumney, emacs-devel
>>>>> ">" == YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
>> Setting CC on configure no longer works without `--without-gcc'.
>> CC='gcc -arch ppc64' ./configure --without-gcc
I don't see a reason to have --without-gcc at all. The normal
approach is to have the user set CC on the command line and then have
configure detect whether or not it is gcc; AC_PROG_CC will do this.
So what do you think of this?
Tom
ChangeLog:
2008-01-27 Tom Tromey <tromey@redhat.com>
* INSTALL (DETAILED BUILDING AND INSTALLATION): Remove
--with-gcc.
* configure.in (--with-gcc): Remove.
Index: INSTALL
===================================================================
RCS file: /sources/emacs/emacs/INSTALL,v
retrieving revision 1.126
diff -u -r1.126 INSTALL
--- INSTALL 8 Jan 2008 20:46:40 -0000 1.126
+++ INSTALL 27 Jan 2008 22:57:45 -0000
@@ -270,11 +270,6 @@
PATH is the pathname to pkg-config. Note that GTK version 2.4 or
newer is required for Emacs.
-The `--with-gcc' option specifies that the build process should
-compile Emacs using GCC. If you don't want to use GCC, specify
-`--with-gcc=no'. If you omit this option, `configure' will search
-for GCC in your path, and use it if present.
-
The Emacs mail reader RMAIL is configured to be able to read mail from
a POP3 server by default. Versions of the POP protocol older than
POP3 are not supported. For Kerberos-authenticated POP add
Index: configure.in
===================================================================
RCS file: /sources/emacs/emacs/configure.in,v
retrieving revision 1.502
diff -u -r1.502 configure.in
--- configure.in 27 Jan 2008 16:06:01 -0000 1.502
+++ configure.in 27 Jan 2008 22:57:46 -0000
@@ -70,11 +70,6 @@
m4_bpatsubst([with_$1], [[^0-9a-z]], [_])=yes])dnl
])dnl
-dnl By default, neither off nor on.
-AC_ARG_WITH([gcc],
-[AS_HELP_STRING([--without-gcc],
- [don't use GCC to compile Emacs even if GCC is found])])
-
OPTION_DEFAULT_ON([pop],[don't support POP mail retrieval with movemail])
if test "$with_pop" = yes; then
AC_DEFINE(MAIL_USE_POP)
@@ -817,11 +812,6 @@
# Save the value of CFLAGS that the user specified.
SPECIFIED_CFLAGS="$CFLAGS"
-case ${with_gcc} in
- "yes" ) CC="gcc" GCC=yes ;;
- "no" ) : ${CC=cc} ;;
- * )
-esac
AC_PROG_CC
# On Suns, sometimes $CPP names a directory.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2008-01-27 22:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87sl0o5wtf.GNU\\\'s_Not_Unix!%yavor@gnu.org>
2008-01-23 21:23 ` 23.0.50; Image support disabled by default? Adolfo De Unanue
2008-01-23 21:58 ` Yavor Doganov
2008-01-23 16:30 Yavor Doganov
2008-01-23 16:44 ` Tom Tromey
2008-01-23 17:17 ` Jason Rumney
2008-01-23 17:21 ` Yavor Doganov
2008-01-23 18:40 ` Tom Tromey
2008-01-25 4:37 ` Glenn Morris
2008-01-25 5:00 ` YAMAMOTO Mitsuharu
2008-01-26 2:24 ` Glenn Morris
2008-01-26 4:55 ` Tom Tromey
2008-01-27 22:27 ` Tom Tromey
2008-01-27 22:20 ` Tom Tromey
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.