From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Guerry Newsgroups: gmane.emacs.devel Subject: Re: New custom faces for rmail.el Date: Tue, 12 Feb 2008 06:49:59 +0000 Message-ID: <87myq66548.fsf@bzg.ath.cx> References: <87skzzf992.fsf@bzg.ath.cx> <87d4r23j4p.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1202799017 17161 80.91.229.12 (12 Feb 2008 06:50:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Feb 2008 06:50:17 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 12 07:50:40 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JOoyU-00070O-DT for ged-emacs-devel@m.gmane.org; Tue, 12 Feb 2008 07:50:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JOoy1-0002Rl-3a for ged-emacs-devel@m.gmane.org; Tue, 12 Feb 2008 01:50:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JOoxw-0002OE-1y for emacs-devel@gnu.org; Tue, 12 Feb 2008 01:50:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JOoxu-0002Jf-2o for emacs-devel@gnu.org; Tue, 12 Feb 2008 01:50:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JOoxt-0002JU-WF for emacs-devel@gnu.org; Tue, 12 Feb 2008 01:50:02 -0500 Original-Received: from ug-out-1314.google.com ([66.249.92.169]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JOoxt-00045Y-DM for emacs-devel@gnu.org; Tue, 12 Feb 2008 01:50:01 -0500 Original-Received: by ug-out-1314.google.com with SMTP id a2so465067ugf.48 for ; Mon, 11 Feb 2008 22:50:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; bh=fWfHD7sBfbP7Busuem2PaU782M2YI3YumgMlpTrxVew=; b=OdWCR2j1EtFbkCiDYx3wfe5lNFNAMXYTvkKLg1LBmWWxzH80hZiwPyy5eHgd4b/+9mry0bMk6GtuszkZxcgdmAoAcm1b7gmTPnpXTfC4WvgPolckp1Z0LH7PU1FOXF1yYndKYrcG1vlo6S240Yd8azsLRaXRQaq3fVk9MDI7g6M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; b=Cgd07zOGIH/L4m6ingAKVJEy/EBw8A/O3cg40Upv6tRTvCwp2H9g9gEpcI3q4qNIqtYCCt9JTdNd6YX8yZwam9u0odfQLbHQ4kXn/8y61Z2JnENwTN1vNSH9chqXlzNaPUjV5T5D618fAKQrZkdGU6/mP5mQNAbIlL/fb+bufK8= Original-Received: by 10.67.116.4 with SMTP id t4mr178781ugm.68.1202799000019; Mon, 11 Feb 2008 22:50:00 -0800 (PST) Original-Received: from bzg.ath.cx ( [81.99.213.34]) by mx.google.com with ESMTPS id m1sm9065454uge.69.2008.02.11.22.49.58 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Feb 2008 22:49:59 -0800 (PST) Original-Received: by bzg.ath.cx (Postfix, from userid 1000) id 9E92B158253; Tue, 12 Feb 2008 06:49:59 +0000 (GMT) In-Reply-To: (Glenn Morris's message of "Tue, 12 Feb 2008 00:46:20 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:88841 Archived-At: Glenn Morris writes: > Bastien wrote: > >> +(defface rmail-header-name-face >> + '((t (:inherit font-lock-function-name-face))) >> + "Face to use for highlighting the header names." >> + :group 'rmail-headers >> + :version "22.1") > > "23.1" > > Face names should not end in -face. Yes, I know, typo: my intent was to name the face `rmail-header-name' and to name `rmail-header-name-face' the variable that is set to it. >> +(defcustom rmail-header-name 'rmail-header-name-face "\ >> +*Face to use for highlighting the header names." >> + :type '(choice (const :tag "Default" nil) >> + face) >> + :group 'rmail-headers) > > There's no need for a variable, just the face is enough. Okay. But AFAICS there are many places where we have both mistakes: 1) have a face *and* a variable, and 2) name them with the *-face suffix. See for example, font-lock.el: ,---- | (defvar font-lock-comment-delimiter-face 'font-lock-comment-delimiter-face | "Face name to use for comment delimiters.") | | (defvar font-lock-string-face 'font-lock-string-face | "Face name to use for strings.") | | (defvar font-lock-doc-face 'font-lock-doc-face | "Face name to use for documentation.") `---- I think this is very confusing for those who think font-lock.el might be a good place to learn about faces. Shall I fix this? I will fix it in rmail.el when rms tells me when people agree on having (or not) one single face for all rmail headers. -- Bastien