From: Chong Yidong <cyd@stupidchicken.com>
To: Simon Marshall <simon@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [mwelinder@gmail.com: Emacs security bug]
Date: Sat, 10 May 2008 10:50:17 -0400 [thread overview]
Message-ID: <87mymy6wnq.fsf@stupidchicken.com> (raw)
In-Reply-To: <u3aorm9tf.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 May 2008 00:44:44 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> From: "Morten Welinder" <mwelinder@gmail.com>
>
> 1. Create .emacs with contents
> (global-font-lock-mode t)
> (seq font-lock-support-mode 'fast-lock-mode)
>
> 2. Create foo.c with contents /* Nothing to see here */
>
> 3. Create foo.c.flc with contents (message "Something to see here!")
>
> 4. Start Emacs and load foo.c
>
> - --> Observe that code from foo.c.flc is run. Not good.
> (This is with Emacs 21.3.1; XEmacs is also affected, although step 1 needs to
> be adjusted.)
>
> Suggestions:
>
> a. Remove "." from fast-lock-cache-directories. Littering little
> files everywhere is not a good idea anyway.
>
> b. Don't use load to handle the .flc file. Instead read it into a
> buffer and read one s-expression at a time and verify that it is sane
> before evaluating it.
Simon, could you take a look at this (you're listed as the author of
fast-lock.el)?
next prev parent reply other threads:[~2008-05-10 14:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 21:44 [mwelinder@gmail.com: Emacs security bug] Eli Zaretskii
2008-05-09 23:19 ` Chong Yidong
2008-05-10 7:40 ` Eli Zaretskii
2008-05-10 8:28 ` Christian Faulhammer
2008-05-10 14:50 ` Chong Yidong [this message]
2008-05-10 15:16 ` Eli Zaretskii
2008-05-12 10:10 ` Marshall, Simon
2008-05-12 14:31 ` Stefan Monnier
2008-05-12 16:37 ` Marshall, Simon
2008-05-12 17:30 ` Stefan Monnier
2008-05-12 20:14 ` Ulrich Mueller
2008-05-12 20:37 ` Ulrich Mueller
2008-05-13 9:00 ` Marshall, Simon
2008-05-14 14:41 ` Ulrich Mueller
2008-05-14 14:52 ` Marshall, Simon
2008-05-12 20:45 ` Stefan Monnier
2008-05-12 14:36 ` Florian Weimer
2008-05-12 16:21 ` Marshall, Simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mymy6wnq.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=simon@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.