all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Build failure on M$ (using MSVC): Patch enclosed
Date: Thu, 22 May 2008 22:33:09 +0900	[thread overview]
Message-ID: <87mymi31m2.fsf@catnip.gol.com> (raw)
In-Reply-To: <483570CF.7050902@gnu.org> (Jason Rumney's message of "Thu, 22 May 2008 14:10:39 +0100")

Jason Rumney <jasonr@gnu.org> writes:
>> I think the proper fix is to consistently use either strcasecmp or
>> stricmp (or xstricmp, which we define in xfaces.c, though the other
>> two are widely enough used that it seems unnecessary to define yet
>> another function). Historically we seem to have settled on stricmp
>> except in dosfns.c and unexcw.c, which are only compiled on DOS and
>> Cygwin respectively. Even those should be changed for consistency.
>
> Actually, only Windows code seems to use stricmp in Emacs 22.2, so we
> should probably replace uses of both strcasecmp and stricmp with
> xstricmp for consistency.

But let's change the name to xstrcasecmp, as strcasecmp is the posix/gnu
name.

-miles

-- 
Kilt, n. A costume sometimes worn by Scotchmen [sic] in America and Americans
in Scotland.




      reply	other threads:[~2008-05-22 13:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  4:58 Build failure on M$ (using MSVC): Patch enclosed dhruva
2008-05-20  6:10 ` dhruva
2008-05-20  8:26   ` dhruva
2008-05-20  8:58     ` dhruva
2008-05-20  9:46       ` Jason Rumney
2008-05-20 10:21         ` David Kastrup
2008-05-20 11:57           ` dhruva
2008-05-20 12:01             ` dhruva
2008-05-20 18:26       ` Eli Zaretskii
2008-05-20 12:11     ` Herbert Euler
2008-05-20 18:30       ` Eli Zaretskii
2008-05-20 18:12 ` Eli Zaretskii
2008-05-21  3:13   ` dhruva
2008-05-21 17:28     ` Stefan Monnier
2008-05-22  3:51       ` dhruva
2008-05-22  4:46         ` Stefan Monnier
2008-05-22  5:03           ` dhruva
2008-05-22  6:52             ` David Kastrup
2008-05-22  7:10               ` dhruva
2008-05-22  7:32                 ` David Kastrup
2008-05-22 15:49                 ` Stefan Monnier
2008-05-22 15:45               ` Stefan Monnier
2008-05-22  6:56             ` dhruva
2008-05-23  8:30               ` Eli Zaretskii
2008-05-23  9:15                 ` Jason Rumney
2008-05-22  8:32         ` Jason Rumney
2008-05-22  9:10           ` dhruva
2008-05-22  9:29             ` dhruva
2008-05-22 12:31               ` Jason Rumney
2008-05-22 13:10                 ` Jason Rumney
2008-05-22 13:33                   ` Miles Bader [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mymi31m2.fsf@catnip.gol.com \
    --to=miles@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.