Re: face-remapping patch

[Chong Yidong <cyd@stupidchicken.com>]

Miles Bader <miles@gnu.org> writes:

> Chong Yidong <cyd@stupidchicken.com> writes:
>>> I've attached my face-remapping patch to this message (I needed to
>>> untangle it from some other changes).
>>>
>>> I've used regularly in my personal emacs for many years, and in light
>>> testing the patch seems to work fine against the current trunk.
>>
>> Looks reasonable, but could you explain what problem this solves?  Under
>> what circumstances would a user or an Elisp library prefer to use
>> face-remapping instead of redefining faces directly?
>
> What I personally use it for most of the time is a little
> `variable-pitch-mode' minor mode, which makes the text in the current
> buffer display text using the variable-pitch face.
>
> It's sort of a perennial feature request too ... "Can I somehow
> re-define face XXX in only a single buffer?"

I see.  I think the patch makes good sense.

BTW, off the top of your head, is any existing code in Emacs that could
benefit from using face remapping?  If so, this would be a good time to
change that too.