From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitri Paduchikh Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition Date: Fri, 12 Jun 2009 12:09:56 +0600 Message-ID: <87my8ehtjf.fsf@paduch.telenet.ru> Reply-To: Dmitri Paduchikh , 3541@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1244796895 9445 80.91.229.12 (12 Jun 2009 08:54:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Jun 2009 08:54:55 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 12 10:54:51 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MF2XC-000301-Uk for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jun 2009 10:54:51 +0200 Original-Received: from localhost ([127.0.0.1]:42460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MF2XC-0000GF-0f for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jun 2009 04:54:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MF04v-00005L-7W for bug-gnu-emacs@gnu.org; Fri, 12 Jun 2009 02:17:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MF04o-0008UA-EU for bug-gnu-emacs@gnu.org; Fri, 12 Jun 2009 02:17:27 -0400 Original-Received: from [199.232.76.173] (port=58652 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MF04o-0008U2-7y for bug-gnu-emacs@gnu.org; Fri, 12 Jun 2009 02:17:22 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41650) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MF04n-0007ap-KI for bug-gnu-emacs@gnu.org; Fri, 12 Jun 2009 02:17:21 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5C6HJ4B016957; Thu, 11 Jun 2009 23:17:19 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n5C6F4F6016365; Thu, 11 Jun 2009 23:15:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dmitri Paduchikh Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 12 Jun 2009 06:15:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 3541 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124478704116242 (code B ref -1); Fri, 12 Jun 2009 06:15:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 12 Jun 2009 06:10:41 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5C6AYIa016233 for ; Thu, 11 Jun 2009 23:10:36 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:58465 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MEzyD-0005uz-Tu for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 02:10:33 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MEzyC-0006q8-3C for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 02:10:33 -0400 Original-Received: from k66.ru ([87.224.128.21]:58107) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MEzyB-0006mI-0c for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 02:10:31 -0400 Original-Received: from paduch.telenet.ru (account dpaduch [90.157.67.22] verified) by k66.ru (CommuniGate Pro SMTP 5.1.13) with ESMTPSA id 313380137 for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 12:09:56 +0600 User-Agent: Gnus/5.13 (Gnus v5.13) X-detected-operating-system: by monty-python.gnu.org: FreeBSD 6.x (1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 12 Jun 2009 02:17:27 -0400 X-Mailman-Approved-At: Fri, 12 Jun 2009 04:54:44 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28663 gmane.emacs.pretest.bugs:24619 Archived-At: Here is a patch which adds the missing comma in the macro ad-set-orig-definition. diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index fa5d57a..27c65ec 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -2191,7 +2191,7 @@ Redefining advices affect the construction of an advised definition." (defmacro ad-set-orig-definition (function definition) `(ad-safe-fset - (ad-get-advice-info-field function 'origname) ,definition)) + (ad-get-advice-info-field ,function 'origname) ,definition)) (defmacro ad-clear-orig-definition (function) `(fmakunbound (ad-get-advice-info-field ,function 'origname)))