From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: emacs-devel@gnu.org
Subject: Re: log format for vc-bzr
Date: Fri, 08 Jan 2010 15:39:10 +0100 [thread overview]
Message-ID: <87my0ofypd.fsf@ambire.localdomain> (raw)
In-Reply-To: <831vi0bvx5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Jan 2010 14:52:54 +0200")
() Eli Zaretskii <eliz@gnu.org>
() Fri, 08 Jan 2010 14:52:54 +0200
Yes, I see that now, but if ttn called that ``personal junk'',
then I cannot disagree more. That's the history of my work; I
don't see how someone could object to having it in the public
repository. Without it, some changes, such as inadvertent
merge mistakes, can never be investigated and will remain a
mystery forever.
Although in personal projects i don't commit with the specific log
entry "gone to lunch", i *do* tend to make lots of small commits
with the pattern: open, futz, close. E.g.:
0 (open) add debug output (printf, message, etc)
1 (futz) split func into producer + consumer; nfc
2 make func take producer
3 update func callers to pass producer
4 add optional arg
5 update docs
6 (close) reindent caller-1
7 remove debug output
The end result of this series then is squashed into one commit
to the "trunk" (or whatever) as:
8 Don't hardcode `func' producer; make callers pass it in.
* src/file.ext (func) Take two more args: PRODUCER, OPTION.
(caller-1, caller-2): Update calls to `func'.
* doc/stuff.texi (API Infernals): Update `func' intro, docs.
I consider commits 0, 6 and 7 (open, close) to be ``personal
junk'' (ruminative, not so interesting, and potentially confusing
for ttn-in-six-months (weeks?, hours?)). Commits 1-5, on the
other hand, are interesting, but are not of publishable quality
for two reasons: (a) they introduce inconsistent state -- 2
introduces arity mismatch; (b) their log entries are incomplete
(albeit useful to synthesize later). I believe publishing those
as discrete commits would only add noise; they, too are ``personal
junk''.
Note that even though it is 8 that gets published, i can keep
0-7 in a local branch, untouched, for as long as i wish. Now,
it's not just personal, it's perpetual!
Perhaps i should add that i don't find junk objectionable; what
conscious bit-recycler and occasional garbage collector would?
thi
next prev parent reply other threads:[~2010-01-08 14:39 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 17:47 log format for vc-bzr Dan Nicolaescu
2009-12-08 19:19 ` Óscar Fuentes
2009-12-08 19:47 ` Andreas Schwab
2009-12-08 20:15 ` Óscar Fuentes
2009-12-08 21:10 ` Andreas Schwab
2009-12-08 22:03 ` Dan Nicolaescu
2009-12-08 22:36 ` Óscar Fuentes
2009-12-09 0:27 ` Jason Earl
2009-12-09 8:55 ` Andreas Schwab
2009-12-09 9:55 ` Stephen J. Turnbull
2009-12-09 14:41 ` Stefan Monnier
2009-12-09 20:29 ` Óscar Fuentes
2009-12-09 21:49 ` Andreas Schwab
2009-12-09 22:34 ` Óscar Fuentes
2009-12-09 23:15 ` Andreas Schwab
2009-12-10 2:03 ` Stephen J. Turnbull
2009-12-10 9:12 ` Andreas Schwab
2009-12-10 12:28 ` Stephen J. Turnbull
2010-01-07 21:23 ` Thien-Thi Nguyen
2010-01-07 21:47 ` Óscar Fuentes
2010-01-08 0:40 ` Thien-Thi Nguyen
2010-01-08 9:00 ` Eli Zaretskii
2010-01-08 10:09 ` reversion revulsion [was: log format for vc-bzr] Thien-Thi Nguyen
2010-01-08 10:53 ` Juanma Barranquero
2010-01-08 13:41 ` reversion revulsion Thien-Thi Nguyen
2010-01-08 14:32 ` Juanma Barranquero
2010-01-08 14:47 ` Thien-Thi Nguyen
2010-01-08 11:21 ` reversion revulsion [was: log format for vc-bzr] Óscar Fuentes
2010-01-08 12:36 ` Eli Zaretskii
2010-01-08 13:27 ` reversion revulsion Óscar Fuentes
2010-01-08 16:54 ` Eli Zaretskii
2010-01-08 17:57 ` Óscar Fuentes
2010-01-08 13:29 ` reversion revulsion [was: log format for vc-bzr] Juanma Barranquero
2010-01-08 13:32 ` Juanma Barranquero
2010-01-08 10:28 ` log format for vc-bzr Juanma Barranquero
2010-01-08 12:01 ` Eli Zaretskii
2010-01-08 12:24 ` Juanma Barranquero
2010-01-08 12:52 ` Eli Zaretskii
2010-01-08 13:22 ` Juanma Barranquero
2010-01-08 13:50 ` Andreas Schwab
2010-01-08 14:28 ` Juanma Barranquero
2010-01-08 14:39 ` Thien-Thi Nguyen [this message]
2010-01-08 17:56 ` bzr Q&A [was Re: log format for vc-bzr] Glenn Morris
2010-01-09 10:35 ` Eli Zaretskii
2010-01-09 17:58 ` Stephen J. Turnbull
2010-01-08 10:50 ` log format for vc-bzr Stephen J. Turnbull
2010-01-08 12:20 ` Eli Zaretskii
2010-01-08 12:29 ` Juanma Barranquero
2010-01-08 13:39 ` Stephen J. Turnbull
2010-01-09 10:51 ` Eli Zaretskii
2010-01-08 13:48 ` Óscar Fuentes
2010-01-08 16:57 ` Eli Zaretskii
2010-01-08 17:45 ` Óscar Fuentes
2010-01-08 19:35 ` Eli Zaretskii
2010-01-08 19:41 ` Miles Bader
2010-01-08 21:22 ` Eli Zaretskii
2010-01-08 20:46 ` Óscar Fuentes
2010-01-08 21:29 ` Eli Zaretskii
2010-01-08 21:51 ` Óscar Fuentes
2010-01-08 22:24 ` Eli Zaretskii
2010-01-08 23:05 ` Óscar Fuentes
2010-01-09 8:50 ` Thien-Thi Nguyen
2010-01-09 9:36 ` Andreas Schwab
2010-01-09 13:35 ` Thien-Thi Nguyen
2010-01-09 3:45 ` Miles Bader
2010-01-08 11:54 ` Daniel Clemente
2010-01-08 16:45 ` Eli Zaretskii
2010-01-09 3:18 ` Daniel Clemente
2010-01-09 9:37 ` Eli Zaretskii
2009-12-09 1:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87my0ofypd.fsf@ambire.localdomain \
--to=ttn@gnuvola.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.