From: Chong Yidong <cyd@stupidchicken.com>
To: Deniz Dogan <deniz.a.m.dogan@gmail.com>
Cc: 5732@debbugs.gnu.org
Subject: bug#5732: css-mode doesn't correctly highlight "grouped" selectors
Date: Sat, 10 Apr 2010 13:16:30 -0400 [thread overview]
Message-ID: <87mxxbjki9.fsf@stupidchicken.com> (raw)
In-Reply-To: <7b501d5c1003170425t50af9a6bhd52eb01df72b4682@mail.gmail.com>
> css-mode doesn't seem to correctly highlight anything but the last
> selector if grouping them as such:
>
> #topic span,
> #topic b,
> #topic i {
> ...
> }
How bout something like this?
*** lisp/textmodes/css-mode.el 2010-01-13 08:35:10 +0000
--- lisp/textmodes/css-mode.el 2010-04-10 17:13:44 +0000
***************
*** 236,242 ****
;; thus prevent this highlighting from being applied (actually now that
;; I use `append' this should work better). But really the part of hte
;; selector between [...] should simply not be highlighted.
! (,(concat "^\\([ \t]*[^@:{\n][^:{\n]+\\(?::" (regexp-opt css-pseudo-ids t)
"\\(?:([^)]+)\\)?[^:{\n]*\\)*\\)\\(?:\n[ \t]*\\)*{")
(1 'css-selector append))
;; In the above rule, we allow the open-brace to be on some subsequent
--- 236,242 ----
;; thus prevent this highlighting from being applied (actually now that
;; I use `append' this should work better). But really the part of hte
;; selector between [...] should simply not be highlighted.
! (,(concat "^\\([ \t]*[^@:{}\n][^:{}]+\\(?::" (regexp-opt css-pseudo-ids t)
"\\(?:([^)]+)\\)?[^:{\n]*\\)*\\)\\(?:\n[ \t]*\\)*{")
(1 'css-selector append))
;; In the above rule, we allow the open-brace to be on some subsequent
next prev parent reply other threads:[~2010-04-10 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 11:25 bug#5732: css-mode doesn't correctly highlight "grouped" selectors Deniz Dogan
2010-04-10 17:16 ` Chong Yidong [this message]
2010-06-24 22:56 ` bug#5732: Deniz Dogan
2011-09-18 19:24 ` bug#5732: css-mode doesn't correctly highlight "grouped" selectors Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxxbjki9.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=5732@debbugs.gnu.org \
--cc=deniz.a.m.dogan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.