From: "Štěpán Němec" <stepnem@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Jari Aalto <jari.aalto@cante.net>, 7408@debbugs.gnu.org
Subject: bug#7408: Linux patchutils: Development of the project?
Date: Wed, 17 Nov 2010 13:47:04 +0100 [thread overview]
Message-ID: <87mxp8kth3.fsf@gmail.com> (raw)
In-Reply-To: <jwv4obggbcg.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 16 Nov 2010 17:21:27 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> subr.el has had a dolist definition since at least Emacs 21.x; ie 9 years.
>>> Therefore this cannot be a major issue in practice.
>> In my book it is still a bug, no matter how many years ago this bug were
>> introduced:
>
>> - To have two different implementations of same function.
>> - To not be able to rely on uniform behavior.
>
> You look at it the wrong way: the problem is not with dolist, it's that
> you use `return' which is a special form that's not defined in standard
> Elisp. After (require 'cl), `return' gets defined and things work as
> you expect.
While I don't share Jari's complaint in general (i.e., the approach "if
you only want the subr.el dolist, you don't care if it's really CL
dolist you end up calling; if you want the CL dolist, you require 'cl
and are done with it" has served me acceptably well), I've always
wondered what the hell was the person adding another function of the
same name thinking. To have a library that clobbers existing definitions
is a no no even outside Emacs, let alone in the core.
Is the explanation (I'm not familiar with the history) that at the time
cl.el was added there was no dolist in core Emacs, so there was no
perceived need to call it dolist* as in other similar cases (mapcar*,
defun* etc)? (In that case my sincere disdain would go for the person
who introduced dolist into subr.el later without addressing the naming
clash.)
Same with `dotimes'.
Štěpán
next prev parent reply other threads:[~2010-11-17 12:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <r6eo4w45.fsf@blue.sea.net>
[not found] ` <1213200935.4147.62.camel@cyberelk.elk>
2010-10-16 13:42 ` bug#7227: re-search-forward goes infinite loop with dash inside [] Jari Aalto
2010-10-16 13:54 ` Andreas Schwab
2010-11-16 21:25 ` bug#7408: Linux patchutils: Development of the project? Jari Aalto
2010-11-16 21:59 ` Lennart Borgman
2010-11-16 22:21 ` Stefan Monnier
2010-11-17 4:47 ` jari
2010-11-17 8:25 ` Glenn Morris
2010-11-17 13:39 ` Stefan Monnier
2010-11-17 12:47 ` Štěpán Němec [this message]
2010-11-17 13:39 ` Stefan Monnier
2010-11-18 22:02 ` bug#7408: 23.2.1 dolist -- subr.el and cl-macs differ with nil-block return Jari Aalto
2010-11-21 5:45 ` Stefan Monnier
2010-11-21 9:08 ` jari
2010-11-21 17:49 ` Eli Zaretskii
2010-11-21 18:51 ` Stefan Monnier
2010-11-17 14:18 ` bug#7408: Linux patchutils: Development of the project? martin rudalics
2010-11-15 10:51 bug#7408: 23.2.1 dolist -- subr.el and cl-macs differ with nil-block return Jari Aalto
2010-11-21 23:19 ` bug#7408: Linux patchutils: Development of the project? MON KEY
-- strict thread matches above, loose matches on Subject: below --
2010-10-16 9:16 bug#7227: re-search-forward goes infinite loop with dash inside [] Jari Aalto
2010-10-16 11:27 ` Andreas Schwab
2010-10-16 11:39 ` Andreas Röhler
2010-10-22 7:55 ` bug#7227: Close bts:gnu Jari Aalto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxp8kth3.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=7408@debbugs.gnu.org \
--cc=jari.aalto@cante.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.