From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert colors to hexadecimal with shr-color->hexadecimal. Date: Tue, 23 Nov 2010 16:31:30 -0500 Message-ID: <87mxoz7mml.fsf@stupidchicken.com> References: <961v6bom3j.fsf@fencepost.gnu.org> <87eiabdc04.fsf@stupidchicken.com> <87ipznhhe3.fsf@keller.adm.naquadah.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1290547922 7399 80.91.229.12 (23 Nov 2010 21:32:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 23 Nov 2010 21:32:02 +0000 (UTC) Cc: Katsumi Yamaoka To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 23 22:31:57 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PL0Su-00026O-CY for ged-emacs-devel@m.gmane.org; Tue, 23 Nov 2010 22:31:52 +0100 Original-Received: from localhost ([127.0.0.1]:60928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PL0St-00009B-Lx for ged-emacs-devel@m.gmane.org; Tue, 23 Nov 2010 16:31:51 -0500 Original-Received: from [140.186.70.92] (port=34106 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PL0Sl-00008g-8p for emacs-devel@gnu.org; Tue, 23 Nov 2010 16:31:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PL0Sg-0000f0-Av for emacs-devel@gnu.org; Tue, 23 Nov 2010 16:31:43 -0500 Original-Received: from pantheon-po26.its.yale.edu ([130.132.50.121]:56750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PL0Sa-0000e8-Sd; Tue, 23 Nov 2010 16:31:32 -0500 Original-Received: from furball (dhcp128036226124.central.yale.edu [128.36.226.124]) (authenticated bits=0) by pantheon-po26.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id oANLVVYW022059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 23 Nov 2010 16:31:31 -0500 Original-Received: by furball (Postfix, from userid 1000) id 4A312160AC8; Tue, 23 Nov 2010 16:31:31 -0500 (EST) In-Reply-To: <87ipznhhe3.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Tue, 23 Nov 2010 22:14:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133088 Archived-At: Julien Danjou writes: > On Tue, Nov 23 2010, Chong Yidong wrote: > >> Why is this non-gnus-related library being checked into the Gnus >> repository? > > Because it is used by Gnus? By that logic, we should move all of Emacs into the Gnus tree. This is a general purpose library, not specific to Gnus. It really ought to be moved out into the Emacs tree. If no one objects, I'm going to move it. Also, it is going to have be be fixed. For example, it violates function naming conventions---some functions start with `color-lab', others with `lab', and still others with no prefix at all. All this could have been caught if you'd posted the file to emacs-devel and gone through the usual process of getting a library into the Emacs tree.