From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bug in 23.2.92 with anything Date: Mon, 17 Jan 2011 19:09:49 +0100 Message-ID: <87mxmzcsgi.fsf@gmail.com> References: <87aaj2asy4.fsf@gmail.com> <4D31FDEC.9050508@gmx.at> <878vylonnl.fsf@stupidchicken.com> <4D32178A.7090308@gmx.at> <87d3nx23w2.fsf@gmail.com> <4D32360B.7030007@gmx.at> <87y66l48t4.fsf@gmail.com> <4D32CA53.20004@gmx.at> <874o97hnb6.fsf@gmail.com> <4D3419E2.8070508@gmx.at> <87tyh72103.fsf@gmail.com> <4D3480D7.1070303@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1295287871 25589 80.91.229.12 (17 Jan 2011 18:11:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 17 Jan 2011 18:11:11 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 17 19:11:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PetXm-0003JW-Fq for ged-emacs-devel@m.gmane.org; Mon, 17 Jan 2011 19:11:06 +0100 Original-Received: from localhost ([127.0.0.1]:36349 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PetXl-0003cn-TH for ged-emacs-devel@m.gmane.org; Mon, 17 Jan 2011 13:11:05 -0500 Original-Received: from [140.186.70.92] (port=33787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PetWe-00036r-RX for emacs-devel@gnu.org; Mon, 17 Jan 2011 13:09:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PetWd-0004qF-B8 for emacs-devel@gnu.org; Mon, 17 Jan 2011 13:09:56 -0500 Original-Received: from mail-fx0-f41.google.com ([209.85.161.41]:33578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PetWd-0004ps-1z for emacs-devel@gnu.org; Mon, 17 Jan 2011 13:09:55 -0500 Original-Received: by fxm12 with SMTP id 12so6254189fxm.0 for ; Mon, 17 Jan 2011 10:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=VZeoarjSHnkZLIs1VZbxi9TduaK+xfkV6p1hjhpIBrY=; b=NVRfdaGdhLhIH6FR5We2whw0NoqAZvjwKw+fNCbxP6aiUlBuFYjoTXUjGr7t7jrVzh GhAgixcn+qbTX/rhx21/DEAvluCK/n4vyOYgv2XfOMuc7ELwffYAxxsmwl1r+UdPPKC3 Fk3a2eDnT3fG+RiwrKA9vIg9LQGFFYm/wiZpQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; b=dDh7cnNFsdu3B1AuRaYPIWZnNyC+wK9cZcSkxICHnmnXBsxwSXymLsqj98wGn0IQrM V/18AVL2h79v8IUePwHxcEPmp8I4usblQr+wzbvZFyrOamoAWdsC0FHBNTXDiWklXdXI 6XrELBeQPhpWPoTJyPPPGoOnTlgOu0RCFQj3U= Original-Received: by 10.223.97.8 with SMTP id j8mr5057920fan.141.1295287794179; Mon, 17 Jan 2011 10:09:54 -0800 (PST) Original-Received: from thierry-MM061 (57.77.197-77.rev.gaoland.net [77.197.77.57]) by mx.google.com with ESMTPS id e6sm1770047fav.8.2011.01.17.10.09.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 17 Jan 2011 10:09:52 -0800 (PST) In-Reply-To: <4D3480D7.1070303@gmx.at> (martin rudalics's message of "Mon, 17 Jan 2011 18:48:07 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134652 Archived-At: martin rudalics writes: >> Here what i changed: >> >> ,---- >> | if (NILP (norecord)) >> | { >> | ++window_select_count; >> | XSETFASTINT (w->use_time, window_select_count); >> | } >> | >> | /* if (EQ (window, selected_window)) */ >> | /* return window; */ >> | if (EQ (window, selected_window)) >> | { >> | inhibit_point_swap = 0; >> | return window; >> | } >> | >> `---- >> >> I have applied these changes on emacs-23 branch after this commit: >> >> ,---- >> | commit d0c73d59998f4686dbb2a0d7b05e16d7161fe75d >> | Author: Stefan Monnier >> | Date: Sun Jan 16 10:40:47 2011 -0500 >> | >> | * image.c (syms_of_image): Don't access XSYMBOL's internals directly. >> `---- >> >> and it seem to work fine :-) >> Thanks. > > So this should hopefully fix my initial proposal. Could you also try > the other patch I sent you? You would have to revert to the state of > the repository for that purpose. It still doesn't apply correctly, could you make a patch in git style on top of:(i use a git repo) ,----[ emacs-23 branch ] | commit d0c73d59998f4686dbb2a0d7b05e16d7161fe75d | Author: Stefan Monnier | Date: Sun Jan 16 10:40:47 2011 -0500 | | * image.c (syms_of_image): Don't access XSYMBOL's internals directly. `---- -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997