From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: dired-mark-pop-up leaves annoying buffers lying around Date: Sat, 19 Feb 2011 13:53:37 -0500 Message-ID: <87mxlrj1ou.fsf@stupidchicken.com> References: <87tygc58on.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1298141628 30493 80.91.229.12 (19 Feb 2011 18:53:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Feb 2011 18:53:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Antoine Levitt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 19 19:53:44 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pqrw7-0002M7-VU for ged-emacs-devel@m.gmane.org; Sat, 19 Feb 2011 19:53:44 +0100 Original-Received: from localhost ([127.0.0.1]:35693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pqrw7-00075d-LT for ged-emacs-devel@m.gmane.org; Sat, 19 Feb 2011 13:53:43 -0500 Original-Received: from [140.186.70.92] (port=53114 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pqrw3-00075W-M7 for emacs-devel@gnu.org; Sat, 19 Feb 2011 13:53:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pqrw2-0006NE-JW for emacs-devel@gnu.org; Sat, 19 Feb 2011 13:53:39 -0500 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]:48405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pqrw2-0006Mo-HF for emacs-devel@gnu.org; Sat, 19 Feb 2011 13:53:38 -0500 Original-Received: from furball ([64.134.67.165]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1JIrauV008920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 Feb 2011 13:53:36 -0500 Original-Received: by furball (Postfix, from userid 1000) id B9E3416081E; Sat, 19 Feb 2011 13:53:37 -0500 (EST) In-Reply-To: <87tygc58on.fsf@gmail.com> (Antoine Levitt's message of "Thu, 10 Feb 2011 14:19:04 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136233 Archived-At: Antoine Levitt writes: > Any reason not to do the following? > > === modified file 'lisp/dired.el' > --- lisp/dired.el 2011-02-02 16:21:52 +0000 > +++ lisp/dired.el 2011-02-10 13:14:32 +0000 > @@ -2840,7 +2840,8 @@ > '(mouse-face nil help-echo nil))) > (save-window-excursion > (dired-pop-to-buffer bufname) > - (apply function args)))) > + (apply function args) > + (kill-buffer bufname)))) > > (defun dired-format-columns-of-files (files) > (let ((beg (point))) Most callers of dired-mark-pop-up use the default " *Marked Files*" buffer (and AFAICT the others use a fixed name instead of creating unique buffers). The buffer name has a space in front of its name, so it doesn't show up in the buffer list. Any reason why it needs to be killed?