all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Johan Bockgård" <bojohan@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: post-command-hook
Date: Sun, 03 Apr 2011 00:38:15 +0200	[thread overview]
Message-ID: <87mxk8mg88.fsf@gnu.org> (raw)
In-Reply-To: <jwvaag849js.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 02 Apr 2011 17:40:17 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> (defun foo ()
>>   (message "foo"))
>> (defun bar ()
>>   (message "bar"))
>> (add-hook 'post-command-hook 'foo)
>> (add-hook 'post-command-hook 'bar nil t)
>
> I think the patch below fixes it,
>

>  safe_run_hooks_1 (void)
>  {
>    eassert (CONSP (Vinhibit_quit));
> -  return call0 (XCDR (Vinhibit_quit));
> +  call0 (XCDR (Vinhibit_quit));
> +  return Qnil;
>  }

Shouldn't the "return nil" be in safe_run_hook_funcall instead?



  parent reply	other threads:[~2011-04-02 22:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01 15:58 post-command-hook martin rudalics
2011-04-01 18:05 ` post-command-hook Antoine Levitt
2011-04-02  7:02   ` post-command-hook martin rudalics
2011-04-02  8:36     ` post-command-hook Antoine Levitt
2011-04-02 14:25 ` post-command-hook Juanma Barranquero
2011-04-02 21:40 ` post-command-hook Stefan Monnier
2011-04-02 22:00   ` post-command-hook Antoine Levitt
2011-04-02 22:38   ` Johan Bockgård [this message]
2011-04-04  1:09     ` post-command-hook Stefan Monnier
2011-04-03  7:38   ` post-command-hook martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxk8mg88.fsf@gnu.org \
    --to=bojohan@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.