From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.help Subject: Re: emacs 23.3; tramp. remote activity adds extra login info. Date: Mon, 25 Apr 2011 19:42:08 +0200 Message-ID: <87mxjemdn3.fsf@gmx.de> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1303753348 5387 80.91.229.12 (25 Apr 2011 17:42:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Apr 2011 17:42:28 +0000 (UTC) Cc: help-gnu-emacs@gnu.org To: mafeuser@gmail.com Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Apr 25 19:42:24 2011 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QEPnk-00007L-Ez for geh-help-gnu-emacs@m.gmane.org; Mon, 25 Apr 2011 19:42:24 +0200 Original-Received: from localhost ([::1]:46338 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPnk-00008z-4G for geh-help-gnu-emacs@m.gmane.org; Mon, 25 Apr 2011 13:42:24 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPnd-00008j-7x for help-gnu-emacs@gnu.org; Mon, 25 Apr 2011 13:42:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEPnc-000681-0b for help-gnu-emacs@gnu.org; Mon, 25 Apr 2011 13:42:17 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:55932) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1QEPnb-00067f-LB for help-gnu-emacs@gnu.org; Mon, 25 Apr 2011 13:42:15 -0400 Original-Received: (qmail invoked by alias); 25 Apr 2011 17:42:11 -0000 Original-Received: from p57BB95DE.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.149.222] by mail.gmx.net (mp061) with SMTP; 25 Apr 2011 19:42:11 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+uBe4qLseuqRvcFv+heijgv+KL6IFlHz9JIxVBxS IkgETS9dXDaXgb User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:80837 Archived-At: --=-=-= Content-Type: text/plain mafeuser@gmail.com writes: > Hallo all! Hi, > There is one difference to 23.2 though. > > When I compile remotly, compilation buffer gets more verbose login > prompt as it did before. Literally, "NEW" points out changes: > > -*- mode: compilation; default-directory: "/scpc:centos5.x86_64:/tmp/" -*- > Compilation started at Wed Apr 20 15:51:34 > > g++ -g -O3 -o p1 p1.cpp > Last login: Wed Apr 20 17:51:02 2011 from 10.0.2.2 ;; "NEW" > [root@user ~]# ;; "NEW" > Compilation finished at Wed Apr 20 15:51:36 > > is it expected befaviour? Nope, that is an error. The appended patch ought to save it. I'll commit it to both Tramp 2.1 and 2.2 repositories. Will be fixed with Emacs 23.4 (don't know, whether it will come before Emacs 24), and Emacs 24.1. > best regards, > Paul. Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Index: lisp/tramp-smb.el =================================================================== RCS file: /sources/tramp/tramp/lisp/tramp-smb.el,v retrieving revision 2.126.2.1 diff -c -r2.126.2.1 tramp-smb.el *** lisp/tramp-smb.el 24 Jan 2011 10:09:41 -0000 2.126.2.1 --- lisp/tramp-smb.el 25 Apr 2011 17:34:24 -0000 *************** *** 1328,1334 **** ;; Play login scenario. (tramp-process-actions ! p vec (if share tramp-smb-actions-with-share tramp-smb-actions-without-share)) --- 1328,1334 ---- ;; Play login scenario. (tramp-process-actions ! p vec nil (if share tramp-smb-actions-with-share tramp-smb-actions-without-share)) Index: lisp/tramp.el =================================================================== RCS file: /sources/tramp/tramp/lisp/tramp.el,v retrieving revision 2.814.2.13 diff -c -r2.814.2.13 tramp.el *** lisp/tramp.el 12 Mar 2011 12:47:47 -0000 2.814.2.13 --- lisp/tramp.el 25 Apr 2011 17:34:39 -0000 *************** *** 4098,4104 **** (tramp-message v 6 "%s" (mapconcat 'identity (process-command p) " ")) (tramp-set-process-query-on-exit-flag p nil) ! (tramp-process-actions p v tramp-actions-copy-out-of-band)))) ;; Reset the transfer process properties. (tramp-set-connection-property v "process-name" nil) --- 4098,4105 ---- (tramp-message v 6 "%s" (mapconcat 'identity (process-command p) " ")) (tramp-set-process-query-on-exit-flag p nil) ! (tramp-process-actions ! p v nil tramp-actions-copy-out-of-band)))) ;; Reset the transfer process properties. (tramp-set-connection-property v "process-name" nil) *************** *** 6821,6828 **** (setq found (funcall action proc vec))))) found)) ! (defun tramp-process-actions (proc vec actions &optional timeout) ! "Perform actions until success or TIMEOUT." ;; Preserve message for `progress-reporter'. (with-temp-message "" ;; Enable auth-source and password-cache. --- 6822,6832 ---- (setq found (funcall action proc vec))))) found)) ! (defun tramp-process-actions (proc vec pos actions &optional timeout) ! "Perform ACTIONS until success or TIMEOUT. ! PROC and VEC indicate the remote connection to be used. POS, if ! set, is the starting point of the region to be deleted in the ! connection buffer." ;; Preserve message for `progress-reporter'. (with-temp-message "" ;; Enable auth-source and password-cache. *************** *** 6847,6853 **** (cond ((eq exit 'permission-denied) "Permission denied") ((eq exit 'process-died) "Process died") ! (t "Login failed")))))))) ;; Utility functions. --- 6851,6860 ---- (cond ((eq exit 'permission-denied) "Permission denied") ((eq exit 'process-died) "Process died") ! (t "Login failed")))) ! (when (numberp pos) ! (with-current-buffer (tramp-get-connection-buffer vec) ! (let (buffer-read-only) (delete-region pos (point))))))))) ;; Utility functions. *************** *** 7523,7529 **** (catch 'uname-changed (let ((p (tramp-get-connection-process vec)) (process-name (tramp-get-connection-property vec "process-name" nil)) ! (process-environment (copy-sequence process-environment))) ;; If too much time has passed since last command was sent, look ;; whether process is still alive. If it isn't, kill it. When --- 7530,7537 ---- (catch 'uname-changed (let ((p (tramp-get-connection-process vec)) (process-name (tramp-get-connection-property vec "process-name" nil)) ! (process-environment (copy-sequence process-environment)) ! (pos (with-current-buffer (tramp-get-connection-buffer vec) (point)))) ;; If too much time has passed since last command was sent, look ;; whether process is still alive. If it isn't, kill it. When *************** *** 7677,7683 **** ;; Send the command. (tramp-message vec 3 "Sending command `%s'" command) (tramp-send-command vec command t t) ! (tramp-process-actions p vec tramp-actions-before-shell 60) (tramp-message vec 3 "Found remote shell prompt on `%s'" l-host)) ;; Next hop. --- 7685,7691 ---- ;; Send the command. (tramp-message vec 3 "Sending command `%s'" command) (tramp-send-command vec command t t) ! (tramp-process-actions p vec pos tramp-actions-before-shell 60) (tramp-message vec 3 "Found remote shell prompt on `%s'" l-host)) ;; Next hop. --=-=-=--