bug#12186: 24.1.50; defcustom and sets

bug#12186: 24.1.50; defcustom and sets

[Jambunathan K]

Offshoot of bug#12159.

1. C-M-x the below defcustom.

 (defcustom vc-dir-hide-these-states '(up-to-date)
   "States hidden by `vc-dir-hide-some-states'."
   :type '(choice
           (const :tag "None")
           (set :tag "Choices"
                (symbol :tag "VC State" added)
                (symbol :tag "VC State" conflict)
                (symbol :tag "VC State" edited)
                (symbol :tag "VC State" ignored)
                (symbol :tag "VC State" missing)
                (symbol :tag "VC State" needs-merge)
                (symbol :tag "VC State" needs-update)
                (symbol :tag "VC State" removed)
                (symbol :tag "VC State" unlocked-changes)
                (symbol :tag "VC State" unregistered)
                (symbol :tag "VC State" up-to-date)))
   :group 'vc
   :version "24.2")

2. M-x customize-variable RET vc-dir-hide-these-states RET
3. You will see two "up-to-date"s and "added" is missing, from the
choices offered.

 ,----
 | Operate on all settings in this buffer:
 |  Revert...   Apply   Apply and Save 
 | 
 | Hide Vc Dir Hide These States: Value Menu Choices:
 | [X] VC State: up-to-date
 | [ ] VC State: conflict
 | [ ] VC State: edited
 | [ ] VC State: ignored
 | [ ] VC State: missing
 | [ ] VC State: needs-merge
 | [ ] VC State: needs-update
 | [ ] VC State: removed
 | [ ] VC State: unlocked-changes
 | [ ] VC State: unregistered
 | [ ] VC State: up-to-date
 |     State : STANDARD.
 |    States hidden by `vc-dir-hide-some-states'.
 | Groups: Vc
 `----



In GNU Emacs 24.1.50.30 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2012-08-12 on debian-6.05
Bzr revision: 109569 monnier@iro.umontreal.ca-20120811153401-zkhjlvikhyi6r8eh
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
Important settings:
  value of $LANG: en_IN
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t

bug#12186: 24.1.50; defcustom and sets

[Glenn Morris]

Jambunathan K wrote:

>            (set :tag "Choices"
>                 (symbol :tag "VC State" added)
>                 (symbol :tag "VC State" conflict)

You're using it wrong.

elisp "Composite Types"

`(set TYPES...)'
     The value must be a list, and each element of the list must match
     one of the TYPES specified.[...]
     It is not possible to specify two different elements that match
     the same one of TYPES.

You probably want const rather than symbol.

bug#12186: 24.1.50; defcustom and sets

[Jambunathan K]

Glenn Morris <rgm@gnu.org> writes:

> Jambunathan K wrote:
>
>>            (set :tag "Choices"
>>                 (symbol :tag "VC State" added)
>>                 (symbol :tag "VC State" conflict)
>
> You're using it wrong.

Yes.  This is not a bug.

> elisp "Composite Types"
>
> `(set TYPES...)'
>      The value must be a list, and each element of the list must match
>      one of the TYPES specified.[...]
>      It is not possible to specify two different elements that match
>      the same one of TYPES.
>
> You probably want const rather than symbol.