From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#13594: 24.2.92; [PATCH] compilation-start doesn't consider nil OUTWIN Date: Thu, 07 Feb 2013 01:40:47 +0200 Organization: JURTA Message-ID: <87mwvhxehw.fsf@mail.jurta.org> References: <87sj5apclq.fsf@mail.jurta.org> <87r4ktoinh.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360194589 13131 80.91.229.3 (6 Feb 2013 23:49:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Feb 2013 23:49:49 +0000 (UTC) Cc: 13594@debbugs.gnu.org, Leo Liu To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 07 00:50:07 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U3Ekh-0005v0-A7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Feb 2013 00:50:07 +0100 Original-Received: from localhost ([::1]:43489 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3EkO-0005Dd-GX for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Feb 2013 18:49:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3EkL-0005DC-6Z for bug-gnu-emacs@gnu.org; Wed, 06 Feb 2013 18:49:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U3EkK-0004jV-1d for bug-gnu-emacs@gnu.org; Wed, 06 Feb 2013 18:49:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3EkJ-0004jQ-Us for bug-gnu-emacs@gnu.org; Wed, 06 Feb 2013 18:49:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U3ElZ-0001DC-Kn for bug-gnu-emacs@gnu.org; Wed, 06 Feb 2013 18:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Feb 2013 23:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13594-submit@debbugs.gnu.org id=B13594.13601946474632 (code B ref 13594); Wed, 06 Feb 2013 23:51:01 +0000 Original-Received: (at 13594) by debbugs.gnu.org; 6 Feb 2013 23:50:47 +0000 Original-Received: from localhost ([127.0.0.1]:40188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3ElL-0001Cf-4F for submit@debbugs.gnu.org; Wed, 06 Feb 2013 18:50:47 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:46650 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U3ElH-0001CQ-MR for 13594@debbugs.gnu.org; Wed, 06 Feb 2013 18:50:44 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 42500200EC17FD; Wed, 6 Feb 2013 15:49:23 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 06 Feb 2013 10:35:31 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70790 Archived-At: >> (add-to-list 'display-buffer-alist '("\\*compilation\\*" ignore-t (nil))) >> where `ignore-t' is like existing `ignore' but returns t instead of nil: >> (defun ignore-t (&rest _) t) > > Problem is that the functions in display-buffer-alist are supposed to > return either the window they used or nil (to mean that display-buffer > should try the next candidate function). > > So returning t is incorrect and can/will lead to bugs further down where > the caller does not expect a t value (most callers of display-buffer > don't expect a nil return value either). Since there are more buffer names that users might want to not display (e.g. "*Async Shell Command*") it makes sense to improve the buffer-displaying framework with a new feature that would allow the user to associate a buffer name with an inaction for which `display-buffer' will return nil (since nil is a valid return value it's a bug when callers of `display-buffer' don't check for nil, these callers should be fixed).