From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nic Ferrier Newsgroups: gmane.emacs.devel Subject: ERT should/should-not simple fixes Date: Sun, 07 Apr 2013 17:15:41 +0100 Message-ID: <87mwtaqpua.fsf@ferrier.me.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365351363 17297 80.91.229.3 (7 Apr 2013 16:16:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Apr 2013 16:16:03 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 07 18:16:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOsGD-0004v3-FZ for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2013 18:16:05 +0200 Original-Received: from localhost ([::1]:59357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOsGD-00013W-1m for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2013 12:16:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOsG7-000128-6W for emacs-devel@gnu.org; Sun, 07 Apr 2013 12:16:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOsFz-0003u5-Kt for emacs-devel@gnu.org; Sun, 07 Apr 2013 12:15:58 -0400 Original-Received: from static.17.66.46.78.clients.your-server.de ([78.46.66.17]:57608 helo=po1.ferrier.me.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOsFy-0003tH-Tc for emacs-devel@gnu.org; Sun, 07 Apr 2013 12:15:51 -0400 Original-Received: from nferrier (140.35.155.90.in-addr.arpa [90.155.35.140]) by po1.ferrier.me.uk (Postfix) with ESMTP id 8F383AC02A7; Sun, 7 Apr 2013 18:24:27 +0200 (CEST) Original-Received: from nferrier (localhost [127.0.0.1]) by nferrier (Postfix) with ESMTPS id 27D3E1600B7; Sun, 7 Apr 2013 17:15:45 +0100 (BST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 78.46.66.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158758 Archived-At: I've suggested this fix a couple of times. There is currently a bug (perhaps a feature) in 24.3 with the should and should-not macros. This patch "fixes" it: --- /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/ert.el.gz.~1~ +++ /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/ert.el.gz @@ -464,6 +464,7 @@ "Evaluate FORM. If it returns nil, abort the current test as failed. Returns the value of FORM." + (declare (debug (form))) (ert--expand-should `(should ,form) form (lambda (inner-form form-description-form value-var) `(unless ,inner-form @@ -473,6 +474,7 @@ "Evaluate FORM. If it returns non-nil, abort the current test as failed. Returns nil." + (declare (debug (form))) (ert--expand-should `(should-not ,form) form (lambda (inner-form form-description-form value-var) `(unless (not ,inner-form)