* ERT should/should-not simple fixes
@ 2013-04-07 16:15 Nic Ferrier
2013-04-07 18:56 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Nic Ferrier @ 2013-04-07 16:15 UTC (permalink / raw)
To: emacs-devel
I've suggested this fix a couple of times.
There is currently a bug (perhaps a feature) in 24.3 with the should and
should-not macros. This patch "fixes" it:
--- /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/ert.el.gz.~1~
+++ /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/ert.el.gz
@@ -464,6 +464,7 @@
"Evaluate FORM. If it returns nil, abort the current test as failed.
Returns the value of FORM."
+ (declare (debug (form)))
(ert--expand-should `(should ,form) form
(lambda (inner-form form-description-form value-var)
`(unless ,inner-form
@@ -473,6 +474,7 @@
"Evaluate FORM. If it returns non-nil, abort the current test as failed.
Returns nil."
+ (declare (debug (form)))
(ert--expand-should `(should-not ,form) form
(lambda (inner-form form-description-form value-var)
`(unless (not ,inner-form)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ERT should/should-not simple fixes
2013-04-07 16:15 ERT should/should-not simple fixes Nic Ferrier
@ 2013-04-07 18:56 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2013-04-07 18:56 UTC (permalink / raw)
To: Nic Ferrier; +Cc: emacs-devel
> I've suggested this fix a couple of times.
> There is currently a bug (perhaps a feature) in 24.3 with the should and
> should-not macros. This patch "fixes" it:
Thanks, installed,
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-07 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-07 16:15 ERT should/should-not simple fixes Nic Ferrier
2013-04-07 18:56 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.