From: Nic Ferrier <nferrier@ferrier.me.uk>
To: emacs-devel@gnu.org
Subject: ERT should/should-not simple fixes
Date: Sun, 07 Apr 2013 17:15:41 +0100 [thread overview]
Message-ID: <87mwtaqpua.fsf@ferrier.me.uk> (raw)
I've suggested this fix a couple of times.
There is currently a bug (perhaps a feature) in 24.3 with the should and
should-not macros. This patch "fixes" it:
--- /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/ert.el.gz.~1~
+++ /home/nferrier/emacs-local-20130401/share/emacs/24.3/lisp/emacs-lisp/ert.el.gz
@@ -464,6 +464,7 @@
"Evaluate FORM. If it returns nil, abort the current test as failed.
Returns the value of FORM."
+ (declare (debug (form)))
(ert--expand-should `(should ,form) form
(lambda (inner-form form-description-form value-var)
`(unless ,inner-form
@@ -473,6 +474,7 @@
"Evaluate FORM. If it returns non-nil, abort the current test as failed.
Returns nil."
+ (declare (debug (form)))
(ert--expand-should `(should-not ,form) form
(lambda (inner-form form-description-form value-var)
`(unless (not ,inner-form)
next reply other threads:[~2013-04-07 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 16:15 Nic Ferrier [this message]
2013-04-07 18:56 ` ERT should/should-not simple fixes Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwtaqpua.fsf@ferrier.me.uk \
--to=nferrier@ferrier.me.uk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.