From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'. Date: Tue, 16 Jul 2013 10:44:57 +0200 Message-ID: <87mwpm99me.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1373964310 11305 80.91.229.3 (16 Jul 2013 08:45:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Jul 2013 08:45:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 16 10:45:12 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uz0sg-0000IS-SU for ged-emacs-devel@m.gmane.org; Tue, 16 Jul 2013 10:45:10 +0200 Original-Received: from localhost ([::1]:57537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz0sf-0003eu-V5 for ged-emacs-devel@m.gmane.org; Tue, 16 Jul 2013 04:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz0sc-0003cp-25 for emacs-devel@gnu.org; Tue, 16 Jul 2013 04:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz0sa-0000mG-Vj for emacs-devel@gnu.org; Tue, 16 Jul 2013 04:45:06 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz0sa-0000gD-NM for emacs-devel@gnu.org; Tue, 16 Jul 2013 04:45:04 -0400 Original-Received: from detlef.gmx.de ([93.202.48.162]) by mail.gmx.com (mrgmx002) with ESMTPS (Nemesis) id 0MOx4J-1V2c380V2V-006PbN; Tue, 16 Jul 2013 10:45:02 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:W8VToHzmdhTZpk7dBhm/np+3DN7LGShHT7qdXzm5v/O4ZQ4EwVq iwtxATUyP/lMXU2ThEia9OzpFmx3iyA/aTo529pvEKIkqCLNd0imljrYqh6vc9JRr9eGG3d 2Ab8+GrH1pkWVM7dYGInMHiLTXF/g8zIX5rR0h2/pYxwVaZoZOjJemLIlyWndzC3WkkBAc+ UQtfdwnJxqFnIOFFNaCPw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161919 Archived-At: Stefan Monnier writes: >> + (ignore-errors >> + (tramp-run-real-handler 'vc-registered (list file)))))))) > > Is it normal/common for (tramp-run-real-handler 'vc-registered (list > file)) to signal an error in some corner cases? No. I have added this as self-defense of Tramp. The error was triggered, when I have opened a file on a NAS via Tramp. I have mounted the emacs source directory there, and I have tried to open a file in that directory. Due to the existence of .../emacs/.bzr, there was a call (process-file "bzr" nil t nil "status" "--no-classify" "README") bzr is not installed on that machine, so this call failed. The real cause of the problem is a design deficiency, I believe. vc-bzr should check, whether bzr is installed. Unfortunately, we have only `executable-find', which works on the local machine. We would need a counterpart of this function for remote machines, like the pairs `call-process'/`process-file' and `start-process'/`start-file-process'. > Stefan Best regards, Michael.