Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'.

Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'.

[Stefan Monnier]

> +	  (ignore-errors
> +	    (tramp-run-real-handler 'vc-registered (list file))))))))

Is it normal/common for (tramp-run-real-handler 'vc-registered (list
file)) to signal an error in some corner cases?


        Stefan

Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'.

[Michael Albinus]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> +	  (ignore-errors
>> +	    (tramp-run-real-handler 'vc-registered (list file))))))))
>
> Is it normal/common for (tramp-run-real-handler 'vc-registered (list
> file)) to signal an error in some corner cases?

No. I have added this as self-defense of Tramp.

The error was triggered, when I have opened a file on a NAS via Tramp. I
have mounted the emacs source directory there, and I have tried to open
a file in that directory.

Due to the existence of .../emacs/.bzr, there was a call

  (process-file "bzr" nil t nil "status" "--no-classify" "README")

bzr is not installed on that machine, so this call failed.

The real cause of the problem is a design deficiency, I believe. vc-bzr
should check, whether bzr is installed. Unfortunately, we have only
`executable-find', which works on the local machine. We would need a
counterpart of this function for remote machines, like the pairs
`call-process'/`process-file' and `start-process'/`start-file-process'.

>         Stefan

Best regards, Michael.

Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'.

[Stefan Monnier]

>>> +	  (ignore-errors
>>> +	    (tramp-run-real-handler 'vc-registered (list file))))))))
>> Is it normal/common for (tramp-run-real-handler 'vc-registered (list
>> file)) to signal an error in some corner cases?
> No. I have added this as self-defense of Tramp.

So an error here indicates an error in some code somewhere.  In this
case, with-demoted-errors is preferable.

> The error was triggered, when I have opened a file on a NAS via Tramp.
> I have mounted the emacs source directory there, and I have tried to
> open a file in that directory.
> Due to the existence of .../emacs/.bzr, there was a call
>   (process-file "bzr" nil t nil "status" "--no-classify" "README")
> bzr is not installed on that machine, so this call failed.

Sounds like a bug in vc-bzr-register.  Could you either try and fix it
there (catching the error right there), or file a bug report for it?


        Stefan

Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'.

[Michael Albinus]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> So an error here indicates an error in some code somewhere.  In this
> case, with-demoted-errors is preferable.

Not for Tramp, it must be backwards compatible. Maybe I could add a
respective compatibility macro to Tramp.

> Sounds like a bug in vc-bzr-register.  Could you either try and fix it
> there (catching the error right there),

Will try.

>         Stefan

Best regards, Michael.

Re: [Emacs-diffs] trunk r113420: * net/tramp-sh.el (tramp-sh-handle-vc-registered): Use `ignore-error'.

[Michael Albinus]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>>> +	  (ignore-errors
>>>> +	    (tramp-run-real-handler 'vc-registered (list file))))))))
>>> Is it normal/common for (tramp-run-real-handler 'vc-registered (list
>>> file)) to signal an error in some corner cases?
>> No. I have added this as self-defense of Tramp.
>
> So an error here indicates an error in some code somewhere.  In this
> case, with-demoted-errors is preferable.

It took almost 4 years, but now I've fixed this.

>> The error was triggered, when I have opened a file on a NAS via Tramp.
>> I have mounted the emacs source directory there, and I have tried to
>> open a file in that directory.
>> Due to the existence of .../emacs/.bzr, there was a call
>>   (process-file "bzr" nil t nil "status" "--no-classify" "README")
>> bzr is not installed on that machine, so this call failed.
>
> Sounds like a bug in vc-bzr-register.  Could you either try and fix it
> there (catching the error right there), or file a bug report for it?

This bug doesn't happen anymore. I don't remember whether I've filed a
bug report, but it is fixed now.

>         Stefan

Best regards, Michael (proud, 'cos I've shortened my todo list).