From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.bugs Subject: bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included) Date: Wed, 02 Oct 2013 19:12:31 +0200 Message-ID: <87mwmrd2bk.fsf@lingonberry.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380832162 21227 80.91.229.3 (3 Oct 2013 20:29:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Oct 2013 20:29:22 +0000 (UTC) To: 15516@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 22:29:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRpWV-0002kn-GO for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2013 22:29:23 +0200 Original-Received: from localhost ([::1]:45069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRpWU-0004Ni-Pc for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2013 16:29:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRpWJ-0004Ie-0H for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:29:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRpWA-0005bJ-G7 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:29:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRpWA-0005bE-Cj for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VRpW9-0006Yv-SN for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2013 16:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2013 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138083210725167 (code B ref -1); Thu, 03 Oct 2013 20:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Oct 2013 20:28:27 +0000 Original-Received: from localhost ([127.0.0.1]:52364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRpVa-0006Xr-Uf for submit@debbugs.gnu.org; Thu, 03 Oct 2013 16:28:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55555) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRPyx-00016Y-Tn for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRPyp-0003Wk-8i for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:13:03 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPyp-0003Wg-62 for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:12:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPyg-00042j-EL for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:12:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRPyU-0003Si-T5 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:12:46 -0400 Original-Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:44212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPyU-0003S1-M0 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:12:34 -0400 Original-Received: by mail-we0-f181.google.com with SMTP id p61so1360687wes.12 for ; Wed, 02 Oct 2013 10:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:user-agent:date:message-id:mime-version :content-type; bh=SgljbpCBtTb1lp+ahSdsQwfQlKc0s230985fHTiLvDs=; b=KUGq3AzFueDIDNlkeajjThl1uuNOVc8EySwj4PCAVggFwhwY2TZznzibIEvMcHcq9l PnP2OkHP7/BCx/3vw2QCo8lvktBhUaguau7mO6S+F+nlm5QdYBDfrj/Z+hbwDrrJGm0w aKbOYEDh6LLpjiKd8n5g+NgLVpHeEczKvVZ80K8z4qk/8ieosWnpiJY6fR93hSlCmwWO 8/lbQPv3Rg0hPoDQMS5XJ1LzWwBqBfdq8NUOYhJPIFWft8bFjiVnsqdImg4hZVGANZhb Y/EqK9Fnjv2B7DNmLfnWSioITS2kXjohwD68fQk3chiqcLWECz/Oi1uGlfaIC1gvFiMh 4Axw== X-Received: by 10.180.105.198 with SMTP id go6mr24490289wib.0.1380733953202; Wed, 02 Oct 2013 10:12:33 -0700 (PDT) Original-Received: from localhost (hel59-4-88-160-125-31.fbx.proxad.net. [88.160.125.31]) by mx.google.com with ESMTPSA id c13sm18421031wib.5.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 02 Oct 2013 10:12:32 -0700 (PDT) User-Agent: Notmuch/0.16+54~g5c19eb4 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Thu, 03 Oct 2013 16:28:24 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78902 Archived-At: In secrets.el, secrets-create-collection is broken (the DBus message signature is wrong and the collection label is not the right one). Here's a fixed version of the function: (defun secrets-create-collection (collection) "Create collection labeled COLLECTION if it doesn't exist. Return the D-Bus object path for collection." (let ((collection-path (secrets-collection-path collection))) ;; Create the collection. (when (secrets-empty-path collection-path) (setq collection-path (secrets-prompt (cadr ;; "CreateCollection" returns the prompt path as second arg. (dbus-call-method :session secrets-service secrets-path secrets-interface-service "CreateCollection" `(:array (:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection))) ""))))) ;; Return object path of the collection. collection-path))