bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included)

bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included)

[Nicolas Petton]

In secrets.el, secrets-create-collection is broken (the DBus message
signature is wrong and the collection label is not the right one).

Here's a fixed version of the function:

(defun secrets-create-collection (collection)
  "Create collection labeled COLLECTION if it doesn't exist.
Return the D-Bus object path for collection."
  (let ((collection-path (secrets-collection-path collection)))
    ;; Create the collection.
    (when (secrets-empty-path collection-path)
      (setq collection-path
	    (secrets-prompt
	     (cadr
	      ;; "CreateCollection" returns the prompt path as second arg.
	      (dbus-call-method
	       :session secrets-service secrets-path
	       secrets-interface-service "CreateCollection"
	       `(:array 
		 (:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection)))
	       "")))))
    ;; Return object path of the collection.
    collection-path))

bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included)

[Michael Albinus]

Nicolas Petton <petton.nicolas@gmail.com> writes:

Hi Nicolas,

> In secrets.el, secrets-create-collection is broken (the DBus message
> signature is wrong and the collection label is not the right one).

Thanks for the report. I have applied a slightly different patch to the
Emacs repository. Please check
<http://bzr.savannah.gnu.org/lh/emacs/trunk/download/head:/secrets.el-20100313201810-6s62gy70hbdnhfs1-1/secrets.el>.

Best regards, Michael.