bug#15938: diff-mode mishandles diff-default-read-only

bug#15938: diff-mode mishandles diff-default-read-only

[Ivan Shmakov]

	In addition to making the -*- Diff -*- buffers read-only when
	diff-default-read-only is non-nil, diff-mode also makes such
	buffers /writable/ when diff-default-read-only is nil, while per
	the documentation, I’d expect for diff-mode to have no effect on
	buffer-read-only in this latter case.

	Please consider the patch below, which seems to fix the issue.

--- diff-mode.el.~1~
+++ diff-mode.el	2013-11-20 19:42:41.000000000 +0000
@@ -1366,7 +1366,8 @@ (define-derived-mode diff-mode fundamental-mode "Diff"
 
   (diff-setup-whitespace)
 
-  (setq buffer-read-only diff-default-read-only)
+  (when diff-default-read-only
+    (setq buffer-read-only t))
   ;; setup change hooks
   (if (not diff-update-on-the-fly)
       (add-hook 'write-contents-functions 'diff-write-contents-hooks nil t)

-- 
FSF associate member #7257

bug#15938: diff-mode mishandles diff-default-read-only

[Glenn Morris]

Version: 24.4

Thanks; applied.

(BTW, we'd probably need a copyright assignment to accept anything more
than 2-3 lines more from you in future. So maybe think about starting
that process if you expect to contribute more.)

bug#15938: diff-mode mishandles diff-default-read-only

[Ivan Shmakov]

>>>>> Glenn Morris <rgm@gnu.org> writes:

 > Version: 24.4 Thanks; applied.

 > (BTW, we'd probably need a copyright assignment to accept anything
 > more than 2-3 lines more from you in future.  So maybe think about
 > starting that process if you expect to contribute more.)

	JFTR, does that mean 2–3 LoC /in total/, or 2–3 LoC
	/per change/?  I have no plans on working on substantial changes
	to Emacs at this moment, though I hope to contribute some more
	trivial bug fixes, just like those I’ve sent recently.

-- 
FSF associate member #7257

bug#15938: diff-mode mishandles diff-default-read-only

[Glenn Morris]

Ivan Shmakov wrote:

>  > (BTW, we'd probably need a copyright assignment to accept anything
>  > more than 2-3 lines more from you in future.  So maybe think about
>  > starting that process if you expect to contribute more.)
>
> 	JFTR, does that mean 2–3 LoC /in total/, or 2–3 LoC
> 	/per change/?  I have no plans on working on substantial changes
> 	to Emacs at this moment, though I hope to contribute some more
> 	trivial bug fixes, just like those I've sent recently.

2-3 lines in total. So if you prefer not to do an assignment, it's best
if future reports just describe what the problem is, without including
patches.