From: Tassilo Horn <tsdh@gnu.org>
To: Andreas Politz <politza@hochschule-trier.de>
Cc: 16090@debbugs.gnu.org
Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark
Date: Mon, 09 Dec 2013 10:13:11 +0100 [thread overview]
Message-ID: <87mwkawfo8.fsf@tsdh.uni-koblenz.de> (raw)
In-Reply-To: <87a9gbb7wi.fsf@hochschule-trier.de> (Andreas Politz's message of "Sun, 08 Dec 2013 17:54:21 +0100")
Andreas Politz <politza@hochschule-trier.de> writes:
> $ emacs -Q some.pdf
>
> C-x r m RET
> C-x k RET
> C-x r b some.pdf RET
>
> Debugger entered--Lisp error: (wrong-type-argument listp t)
> image-mode-winprops(nil)
Indeed.
> The reason is that the buffer is not yet displayed, when
> doc-view-bookmark-jump tries to change the page. This results in, for
> obscure reasons, trying to change the page in which ever window is
> currently selected. Solution: Defer changing the page after
> bookmark--jump-via has displayed the page.
Here's a simpler patch which does also seem to fix the problem by simply
using find-file instead of bookmark's default handler without requiring
a timer.
--8<---------------cut here---------------start------------->8---
=== modified file 'lisp/doc-view.el'
--- lisp/doc-view.el 2013-01-01 09:11:05 +0000
+++ lisp/doc-view.el 2013-12-09 08:55:30 +0000
@@ -1653,14 +1653,11 @@
(defun doc-view-bookmark-jump (bmk)
;; This implements the `handler' function interface for record type
;; returned by `doc-view-bookmark-make-record', which see.
- (prog1 (bookmark-default-handler bmk)
+ (prog1 (find-file (bookmark-get-filename bmk))
(let ((page (bookmark-prop-get bmk 'page)))
(when (not (eq major-mode 'doc-view-mode))
- (doc-view-toggle-display))
- (with-selected-window
- (or (get-buffer-window (current-buffer) 0)
- (selected-window))
- (doc-view-goto-page page)))))
+ (doc-view-toggle-display))
+ (doc-view-goto-page page))))
--8<---------------cut here---------------end--------------->8---
Could you check if that also fixes the issue for you?
And a question concerning the procedure: since this is a fix for a bug
relative to emacs 23, should I commit it on the emacs-24 branch?
Bye,
Tassilo
next prev parent reply other threads:[~2013-12-09 9:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 16:54 bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Andreas Politz
2013-12-09 9:13 ` Tassilo Horn [this message]
2013-12-09 12:33 ` Andreas Politz
2013-12-09 14:56 ` Tassilo Horn
2013-12-09 16:55 ` Glenn Morris
2013-12-10 7:28 ` Tassilo Horn
2013-12-10 2:51 ` Stefan Monnier
2013-12-10 7:53 ` Tassilo Horn
2013-12-10 10:02 ` Andreas Politz
2013-12-10 11:58 ` Andreas Politz
2013-12-10 16:56 ` Andreas Politz
2013-12-10 20:07 ` Tassilo Horn
2013-12-10 22:16 ` Andreas Politz
2013-12-11 4:43 ` Stefan Monnier
2013-12-11 19:08 ` Tassilo Horn
2013-12-20 8:00 ` Tassilo Horn
2013-12-20 8:28 ` Andreas Politz
2013-12-20 13:02 ` Tassilo Horn
2014-04-02 14:43 ` Stefan Monnier
2014-04-04 13:43 ` Tassilo Horn
2014-04-04 15:14 ` Stefan Monnier
2014-04-04 15:53 ` Tassilo Horn
2014-04-04 16:04 ` Glenn Morris
2014-04-04 17:44 ` Tassilo Horn
2013-12-20 14:33 ` Stefan Monnier
2013-12-20 14:36 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwkawfo8.fsf@tsdh.uni-koblenz.de \
--to=tsdh@gnu.org \
--cc=16090@debbugs.gnu.org \
--cc=politza@hochschule-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.