From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115439: * autorevert.el (auto-revert-notify-add-watch): Do not handle symlinked files. Date: Tue, 10 Dec 2013 05:58:18 +0100 Message-ID: <87mwk9uwt1.fsf@gmx.de> References: <83txehxt42.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386651546 429 80.91.229.3 (10 Dec 2013 04:59:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Dec 2013 04:59:06 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 10 05:59:11 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqFPZ-0004T4-Qd for ged-emacs-devel@m.gmane.org; Tue, 10 Dec 2013 05:59:09 +0100 Original-Received: from localhost ([::1]:47219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqFPZ-0003UU-Ez for ged-emacs-devel@m.gmane.org; Mon, 09 Dec 2013 23:59:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqFPB-0002mz-6o for emacs-devel@gnu.org; Mon, 09 Dec 2013 23:58:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqFP5-0003Jp-3x for emacs-devel@gnu.org; Mon, 09 Dec 2013 23:58:45 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:52064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqFP4-0003IT-SV for emacs-devel@gnu.org; Mon, 09 Dec 2013 23:58:39 -0500 Original-Received: from detlef.gmx.de ([87.146.36.199]) by mail.gmx.com (mrgmx003) with ESMTPS (Nemesis) id 0M2cYX-1VXkXw10z7-00sKI9 for ; Tue, 10 Dec 2013 05:58:37 +0100 In-Reply-To: <83txehxt42.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Dec 2013 05:49:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:XFHaniZ1LdLwW9G5y0JB9BtaPw34pWNrnilFWBeiOrYZO1Zv1D7 I9JISacku8F/NmQRcEjcGryZuH9NMjtRKaQqyWBDlLKfCgD2jUzSwLojs9CNTr8jW9QXPl3 PZU9omkrLb1ya1V6gd+0pGjaGXFW/H5SYZlqkr8qvvA+reYNJuD9N7Xjme1h+UCYnPFFpKJ RnYBLCRKJORS4PgOYTo+g== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166253 Archived-At: Eli Zaretskii writes: >> I think this patch is acceptable, but if/when we try to write a generic >> file-watcher Elisp API, it would be good to make this work (probably by >> adding a watcher on the symlink's target). > > It's up to the user to say whether she wants to watch the symlink or > its target, I think. In general I agree. But Stefan was commenting on my change in autorevert.el. Here it is obvious, that the target shall be watched. I believe. Best regards, Michael.