From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#16296: subword.el regexps shouldn't be constants Date: Fri, 03 Jan 2014 13:16:54 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <87mwjdgcbt.fsf@flea.lifelogs.com> References: <52C0B38E.4040401@orcon.net.nz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1388773354 12753 80.91.229.3 (3 Jan 2014 18:22:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Jan 2014 18:22:34 +0000 (UTC) Cc: 16296@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 03 19:22:41 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vz9OK-00009M-LN for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2014 19:22:40 +0100 Original-Received: from localhost ([::1]:51191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz9OK-0004NP-5j for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2014 13:22:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz9OD-0004Jk-4X for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 13:22:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz9Hv-0006OV-Dj for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 13:16:38 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz9Hv-0006OQ-8p for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 13:16:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vz9Hu-0005JG-Bv for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 13:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2014 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16296-submit@debbugs.gnu.org id=B16296.138877292220345 (code B ref 16296); Fri, 03 Jan 2014 18:16:02 +0000 Original-Received: (at 16296) by debbugs.gnu.org; 3 Jan 2014 18:15:22 +0000 Original-Received: from localhost ([127.0.0.1]:60305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz9HG-0005I2-2K for submit@debbugs.gnu.org; Fri, 03 Jan 2014 13:15:22 -0500 Original-Received: from mail-qc0-f169.google.com ([209.85.216.169]:60070) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz9HD-0005Hu-5U for 16296@debbugs.gnu.org; Fri, 03 Jan 2014 13:15:20 -0500 Original-Received: by mail-qc0-f169.google.com with SMTP id r5so15440081qcx.0 for <16296@debbugs.gnu.org>; Fri, 03 Jan 2014 10:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=TRSGASD4YoAnpE3T/8JIk0OECUzgBAmlP09Q3ZkdYBE=; b=FPMh1ZH9u3wdtztHyu+A6ZtWmDuHdU+O+7ulJzcKWhCcMPSRNwqYCkthtbzjTJxT6d RdVYgGGCYJLK7jrzQhrp+h5h7roVY5ihcfKE606is2TGAkfAZr/snD/h56kghkdjZ0dY +UzqQ/cwexC+mV3KcHoDFLyOtIoRh4pC2wpDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=TRSGASD4YoAnpE3T/8JIk0OECUzgBAmlP09Q3ZkdYBE=; b=NBFrDnDt/QPMEeF2Vr1NcX6DngPLFGYhwUgEB2WZjyQqHbnFlkVmvvzXXOH666jcFL W7edmYGCX2mGoyBUeBuy1ZXytoILUD+4ZEY2a40ZUzJ5EtWAQp6mOHEjlVPY60/IHLKR Wxuej4x4EIKBHiS31rfJEOPq4U9f/Et5NwDF5jkXLM55n5tQBvXW1uTIuIuSBgKBIzAf 8IvhlgRcNF3EllCp0fdAu3/ENV7yEeXOl2deLm4Gwdb13rOrn7d9HitWiu49E+H/WW5/ Ql/McEHXQJUAsvYZeQ+a0ARMDGuNeEPlpf//ySBdHA1RMcRIxLOQa6KriV5wRBVe33Q2 0ddw== X-Gm-Message-State: ALoCoQlwRe8j48mpMFpIq4NEoP6NfaJK6UBOl5LmDadTIGVxeTk8OeGIwjJ6XLXJprzG8BfoNRRO X-Received: by 10.224.45.137 with SMTP id e9mr41495097qaf.19.1388772918762; Fri, 03 Jan 2014 10:15:18 -0800 (PST) Original-Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id g1sm80722318qec.9.2014.01.03.10.15.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jan 2014 10:15:18 -0800 (PST) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <52C0B38E.4040401@orcon.net.nz> (Phil Sainty's message of "Mon, 30 Dec 2013 12:43:10 +1300") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82865 Archived-At: On Mon, 30 Dec 2013 12:43:10 +1300 Phil Sainty wrote: PS> I notice that a recent(ish) change in subword.el changed the two PS> regexps (subword-forward-regexp and subword-backward-regexp) into PS> constants. PS> The reason for splitting them out into variables in the first PS> place was to help make subword-mode easily adaptable to other PS> situations where similar functionality was needed, but for different PS> definitions of 'subword'. PS> For the situation where the normal subword-forward/backward-function PS> values are fine and you simply need buffer-local overrides for the PS> regexps, this newer change would seem to be counter-productive. PS> Can we please revert it? For reference, you mean this commit? revno: 113492 fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758 committer: Stefan Monnier branch nick: trunk timestamp: Mon 2013-07-22 12:25:32 -0400 message: * lisp/progmodes/subword.el: Fix boundary case. (subword-forward-regexp): Make it a constant. Wrap optional \\W in its own group. (subword-backward-regexp): Make it a constant. (subword-forward-internal): Don't treat a trailing capital as the beginning of a word. * test/automated/subword-tests.el: New file.