From: Ted Zlatanov <tzz@lifelogs.com>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: 16296@debbugs.gnu.org
Subject: bug#16296: subword.el regexps shouldn't be constants
Date: Fri, 03 Jan 2014 13:16:54 -0500 [thread overview]
Message-ID: <87mwjdgcbt.fsf@flea.lifelogs.com> (raw)
In-Reply-To: <52C0B38E.4040401@orcon.net.nz> (Phil Sainty's message of "Mon, 30 Dec 2013 12:43:10 +1300")
On Mon, 30 Dec 2013 12:43:10 +1300 Phil Sainty <psainty@orcon.net.nz> wrote:
PS> I notice that a recent(ish) change in subword.el changed the two
PS> regexps (subword-forward-regexp and subword-backward-regexp) into
PS> constants.
PS> The reason for splitting them out into variables in the first
PS> place was to help make subword-mode easily adaptable to other
PS> situations where similar functionality was needed, but for different
PS> definitions of 'subword'.
PS> For the situation where the normal subword-forward/backward-function
PS> values are fine and you simply need buffer-local overrides for the
PS> regexps, this newer change would seem to be counter-productive.
PS> Can we please revert it?
For reference, you mean this commit?
revno: 113492
fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758
committer: Stefan Monnier <monnier@iro.umontreal.ca>
branch nick: trunk
timestamp: Mon 2013-07-22 12:25:32 -0400
message:
* lisp/progmodes/subword.el: Fix boundary case.
(subword-forward-regexp): Make it a constant. Wrap optional \\W in its
own group.
(subword-backward-regexp): Make it a constant.
(subword-forward-internal): Don't treat a trailing capital as the
beginning of a word.
* test/automated/subword-tests.el: New file.
next prev parent reply other threads:[~2014-01-03 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 23:43 bug#16296: subword.el regexps shouldn't be constants Phil Sainty
2014-01-03 18:16 ` Ted Zlatanov [this message]
2014-01-03 22:08 ` Stefan Monnier
2014-01-04 11:32 ` Phil Sainty
2014-01-05 5:50 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwjdgcbt.fsf@flea.lifelogs.com \
--to=tzz@lifelogs.com \
--cc=16296@debbugs.gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.