From: Dmitry Gutov <dgutov@yandex.ru>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: 16854@debbugs.gnu.org
Subject: bug#16854: 24.3.50; ert-run-tests-interactively t selector not working
Date: Sun, 23 Feb 2014 19:21:00 +0200 [thread overview]
Message-ID: <87mwhhkao3.fsf@yandex.ru> (raw)
In-Reply-To: <m2a9dh27xv.fsf@gmail.com> (Helmut Eller's message of "Sun, 23 Feb 2014 15:57:16 +0100")
Helmut Eller <eller.helmut@gmail.com> writes:
> When I run this
>
> (require 'ert)
> (ert-deftest infloop0 () (while t))
>
> with: emacs -Q -nw -l infloops.el -f ert
>
> Emacs starts up and asks: "Run tests (default t): "
> If I enter: "t RET"
> then ERT does not run anything and simply writes:
> "Ran 0 tests, 0 results were as expected"
>
> The expected result is that all tests should be executed.
Same here. Apparently, this is fallout from 114803 (bug#9756).
The code before it used `read-from-minibuffer' with t READ argument, so
"t" was converted to `t'. But now `ert-select-tests' receives SELECTOR
as "t".
The patch below fixes it for me.
=== modified file 'lisp/emacs-lisp/ert.el'
--- lisp/emacs-lisp/ert.el 2014-02-04 17:37:08 +0000
+++ lisp/emacs-lisp/ert.el 2014-02-23 17:16:26 +0000
@@ -1882,11 +1882,12 @@
;; defined without cl.
(car ert--selector-history)
"t")))
- (completing-read (if (null default)
- "Run tests: "
- (format "Run tests (default %s): " default))
- obarray #'ert-test-boundp nil nil
- 'ert--selector-history default nil))
+ (intern
+ (completing-read (if (null default)
+ "Run tests: "
+ (format "Run tests (default %s): " default))
+ obarray #'ert-test-boundp nil nil
+ 'ert--selector-history default nil)))
nil))
(unless message-fn (setq message-fn 'message))
(let ((output-buffer-name output-buffer-name)
next prev parent reply other threads:[~2014-02-23 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 14:57 bug#16854: 24.3.50; ert-run-tests-interactively t selector not working Helmut Eller
2014-02-23 17:21 ` Dmitry Gutov [this message]
2014-02-23 18:16 ` Helmut Eller
2014-02-23 21:16 ` Dmitry Gutov
2014-02-24 6:35 ` Helmut Eller
2014-02-24 6:58 ` Nicolas Richard
2014-02-24 14:00 ` Helmut Eller
2014-02-26 2:05 ` Dmitry Gutov
2014-02-24 17:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwhhkao3.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=16854@debbugs.gnu.org \
--cc=eller.helmut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.