From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 17554@debbugs.gnu.org, Roland Winkler <winkler@gnu.org>
Subject: bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window
Date: Wed, 18 Jun 2014 11:07:05 +0300 [thread overview]
Message-ID: <87mwdaiqbm.fsf@mail.jurta.org> (raw)
In-Reply-To: <87sinhprmc.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 07 Jun 2014 02:04:11 +0300")
>>> +(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil)))
>>
>> `display-buffer-alist' has to stay nil by default.
>
> This will do the same without changing the default value of `display-buffer-alist':
More changes are needed (for the trunk to better display *Completions*)
to copy all default actions from `display-buffer-fallback-action', but
replace `display-buffer-use-some-window' with `display-buffer-at-bottom':
=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el 2014-06-02 00:18:22 +0000
+++ lisp/minibuffer.el 2014-06-18 08:01:12 +0000
@@ -1796,7 +1796,21 @@ (defun minibuffer-completion-help (&opti
;; window, mark it as softly-dedicated, so bury-buffer in
;; minibuffer-hide-completions will know whether to
;; delete the window or not.
- (display-buffer-mark-dedicated 'soft))
+ (display-buffer-mark-dedicated 'soft)
+ ;; Disable `pop-up-windows' temporarily to allow
+ ;; `display-buffer--maybe-pop-up-frame-or-window'
+ ;; in the overridden actions below to pop up a frame
+ ;; if `pop-up-frames' is non-nil, but not to pop up a window.
+ ;; Use `display-buffer-at-bottom' to display completions
+ ;; in a window at the bottom of the selected frame.
+ (pop-up-windows nil)
+ (temp-buffer-show-function
+ (lambda (buffer)
+ (temp-buffer-window-show buffer '((display-buffer--maybe-same-window
+ display-buffer-reuse-window
+ display-buffer--maybe-pop-up-frame-or-window
+ display-buffer-at-bottom)
+ (window-height . fit-window-to-buffer))))))
(with-output-to-temp-buffer "*Completions*"
;; Remove the base-size tail because `sort' requires a properly
;; nil-terminated list.
next prev parent reply other threads:[~2014-06-18 8:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:59 bug#17554: 24.3.91; [Regression] re-usage of dired *Marked Files* buffer window Roland Winkler
2014-05-23 1:07 ` Stefan Monnier
2014-05-23 2:17 ` Roland Winkler
2014-05-23 6:06 ` Eli Zaretskii
2014-05-23 7:24 ` martin rudalics
2014-05-23 21:32 ` Juri Linkov
2014-05-27 21:54 ` Juri Linkov
2014-05-27 22:45 ` Roland Winkler
2014-06-05 23:48 ` Juri Linkov
2014-06-06 1:07 ` Stefan Monnier
2014-06-06 4:17 ` Roland Winkler
2014-06-06 23:05 ` Juri Linkov
2014-06-09 16:15 ` Roland Winkler
2014-06-10 0:12 ` Juri Linkov
2014-06-10 6:07 ` martin rudalics
2014-06-10 22:57 ` Juri Linkov
2014-06-11 7:15 ` martin rudalics
2014-06-12 6:33 ` Juri Linkov
2014-06-16 6:51 ` Juri Linkov
2014-06-16 19:49 ` Roland Winkler
2014-06-16 21:47 ` Stefan Monnier
2014-06-17 6:44 ` Juri Linkov
2014-06-18 7:57 ` Juri Linkov
2014-06-06 23:04 ` Juri Linkov
2014-06-18 8:07 ` Juri Linkov [this message]
2014-05-23 5:48 ` Eli Zaretskii
2014-05-23 7:25 ` martin rudalics
2014-05-23 7:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwdaiqbm.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17554@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.