bug#19111: 25.0.50; 32 bits temacs.exe is linked with wrong image-base when built on 64 bit Windows host

["Óscar Fuentes" <ofv@wanadoo.es>]

Eli Zaretskii <eliz@gnu.org> writes:

>> >> +      t=${t#Target: }
>> >
>> > Is this portable to Unix shells?  If not, perhaps use the 'eval' trick
>> > here.
>> 
>> This code is never meant to be executed on other than MSYS(2)/Cygwin.
>> Does the shell complain if an error is present inside an `if' that it
>> doesn't enter? In other words, does the shell perform syntactic checks
>> on code that it doesn't execute?
>
> It does, sometimes.  I'll let experts to tell if this is one of those
> cases.

Ok. Now I have to figure out that 'eval' trick.

> OTOH, we've lived without this test for quites some time, so suddenly
> starting to reject any configurations that might cause this sounds too
> drastic to me.

Until recently there was a very limited set of MSYS/MinGW supported
architectures (one). This problem couldn't happen. Now we have i686 and
x86_64, which makes 4 MSYS/MinGW combinations and, of course, some users
experienced the problem.

IMO it is better to reject those cases where guessing the target
platform might cause cryptic errors later on the build (or at runtime).
The user can pass --target to `configure' to avoid the check, as its
error message says.